2053134 - Simplify idl-analyze.py by having in-tree C++ header generator annotate functions with binding data

Status: RESOLVED FIXED

(Webtools :: Searchfox, enhancement)

Description

[Nicolas Guichard]

Since bug 1865048, the Mozsearch Clang plugin has support for custom annotations __attribute__((annotate("binding_to/bound_as", "LANGUAGE", "KIND", "SEARCHFOX SYMBOL"))). The code generator which generates C++ headers from IDL files could add those annotations which would remove the need for idl-analyze.py to read the C++ analysis to map identifiers to symbols.

Comment 1

[Nicolas Guichard]

Attachment: Bug 2053134 - Force Mozsearch action to run before custom attributes action. r?sergesanspaille!

Since bug 1865048, the Mozsearch Clang plugin can read custom
annotations to get a better understanding of cross-language bindings.

The CustomAttributes action of the main Clang plugin removes all
annotations and used to run before the Mozsearch Clang plugin.

This re-orders the execution of the actions so that the Mozsearch
plugin has a chance to read those annotations before they are stipped
away.

To enforce the order, all action registrations are moved to a new
Registration.cpp file.

Comment 2

[Nicolas Guichard]

Attachment: Bug 2053134 - Add support for IDL bindings in Mozsearch plugin. r?asuth!

This adds the enum value required to also support bindings between C++
and IDL.

Comment 3

[Nicolas Guichard]

Attachment: Bug 2053134 - Add mozsearch binding annotations to C++ headers generated from XPIDL. r?emilio!

This updates the XPIDL C++ header generator to add Mozsearch binding
annotations to the generated declarations.

Those get picked up by the Mozsearch Clang plugin to link between the
C++ classes/functions and their matching XPIDL definition.

Comment 4

[BMO Github Automation]

Authored by https://github.com/nicolas-guichard
https://github.com/mozsearch/mozsearch/commit/dc141a557b190de34cb4b632fd1343053ed6f157
[master] Bug 2053134 - Add support for IDL bindings in Mozsearch plugin

Authored by https://github.com/nicolas-guichard
https://github.com/mozsearch/mozsearch/commit/7e4776b0812471312f78478a5d9e96022013a6c7
[master] Bug 2053134 - Split Clang plugin action registration into separate file

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ae5639c2a014
https://hg.mozilla.org/integration/autoland/rev/20d869b79d90
Force Mozsearch action to run before custom attributes action. r=sergesanspaille
https://github.com/mozilla-firefox/firefox/commit/5c4783a770f7
https://hg.mozilla.org/integration/autoland/rev/d1758040cc33
Add support for IDL bindings in Mozsearch plugin. r=asuth
https://github.com/mozilla-firefox/firefox/commit/053f9f1142b6
https://hg.mozilla.org/integration/autoland/rev/33340b53cee1
Add mozsearch binding annotations to C++ headers generated from XPIDL. r=emilio

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/20d869b79d90
https://hg.mozilla.org/mozilla-central/rev/d1758040cc33
https://hg.mozilla.org/mozilla-central/rev/33340b53cee1