Closed Bug 2053212 Opened 4 months ago Closed 2 months ago

Firefox no longer displays link preview for links with pseudo-element

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

defect

Tracking

()

RESOLVED FIXED
157 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox-esr153 --- wontfix
firefox152 --- wontfix
firefox153 --- wontfix
firefox154 --- wontfix
firefox155 --- wontfix
firefox156 --- wontfix
firefox157 --- verified
firefox158 --- verified

People

(Reporter: soeren.hentzschel, Assigned: mozilla.7fhrv)

References

(Regression)

Details

(Keywords: regression)

Crash Data

Attachments

(1 external file)

Firefox no longer displays a link preview for links with a pseudo-element. This poses a security risk of sorts, as it makes phishing much easier when you can no longer check the link’s destination before clicking on it.

STR:

  1. Open https://www.camp-firefox.de/artikel/1228-mozilla-ver%C3%B6ffentlicht-umfangreiche-firefox-roadmap-f%C3%BCr-alle-plattformen/
  2. Move your mouse over an external link (red text with a "↗" after the text), like "Roadmap-Seite".

Actual:

No link preview. Once you set display: none to the a.externalURL::after, it works again.

Expected:

You see a link preview in the corner of the Firefox window.

Tested on macOS and Windows. According to mozregression, it's a regression from bug 2023374.

Flags: needinfo?(mozilla.7fhrv)

It appears that CSS causes ClearFrameRefs.
This is the reproduction code:

<html><head>
  <style>
    a { display: inline; }
    a::hover { display: inline-flex; }
  </style>
</head><body>
  <a href="https://example.com">foo</a>
</body></html>
Flags: needinfo?(mozilla.7fhrv)

ClearFrameRefs unconditionally cleared the status bar even if the
content was still in the document (e.g. when a CSS change caused the
frame to be reframed).
Only clear the status bar if the content is no longer in the composed
document.

Regressed by: Bug 2023374

Assignee: nobody → mozilla.7fhrv
Status: NEW → ASSIGNED
Severity: -- → S3

Set release status flags based on info from the regressing bug 2023374

Can we please make some progress on this? If the link destination isn't visible before the user clicks, it has security implications (increased risk of phishing).

The author of the regression and the patch used to fix it appears to have been inactive for the past month. See comment #4 for why I think this is a bad regression that has been in the product since Firefox 151, and which I would like to see fixed as soon as possible.

Flags: needinfo?(hsivonen)

(In reply to Sören Hentzschel from comment #5)

The author of the regression and the patch used to fix it appears to have been inactive for the past month. See comment #4 for why I think this is a bad regression that has been in the product since Firefox 151, and which I would like to see fixed as soon as possible.

Sorry, I'm the author, and rather than being inactive, I'm waiting for comment on phabricator.
https://phabricator.services.mozilla.com/D310891#10787728

Flags: needinfo?(hsivonen) → needinfo?(smaug)

Commented in phab.

Flags: needinfo?(smaug)

Sorry, I'm the author, and rather than being inactive, I'm waiting for comment on phabricator.

After re-reading my comment, I think it sounds more accusatory than I intended. Sorry for that! I was just going by the Bugzilla activity and didn't check the Phabricator revision for comments. Thanks for working on this!

Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/999464fe3c9d https://hg.mozilla.org/integration/autoland/rev/53c625ca1242 Revert "Bug 2053212 - Don't clear the status bar just because the frame was reframed. r=smaug" for causing bp-nu bustages.
Flags: needinfo?(mozilla.7fhrv)

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:mozilla.7fhrv, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(smaug)
Flags: needinfo?(mozilla.7fhrv)
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 157 Branch
Flags: needinfo?(smaug)
Flags: needinfo?(mozilla.7fhrv)
Duplicate of this bug: 2067687

Copying crash signatures from duplicate bugs.

Crash Signature: [@ mozilla::RestyleManager::TakeSnapshotForAttributeChange]
QA Whiteboard: [qa-triage-done-c158/b157] [qa-ver-needed-c158/b157]
Flags: qe-verify+
QA Contact: mchiorean

I was able to reproduce the issue on Win11x64 using Firefox build 155.0.
Verified as fixed on Win11x64 using Firefox builds 158.0a1 and 157.0b1. Pending verification on esr 153 if uplifted.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: