2053263 - [HDR/Windows] Memory leak when playing HDR video

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect, P2)

Description

[Ashley Hale [:ahale]]

I did some about:memory comparisons to verify if there are any memory leaks with the new ShaderBlt code (Bug 2037689) and found some, we should fix these before shipping.

Comment 1

[Ashley Hale [:ahale]]

Attachment: Bug 2053263 - Fix some memory leaks with SavedD3D11State helper class r?#gfx-reviewers

Comment 2

[Ashley Hale [:ahale]]

I'm marking this bug as S2 because:

• it is a memory leak - ~200MiB GPU memory per HDR video
• it is a regression (without ShaderBlt code we would not be showing HDR video though)
• there is a plausible user story where something is visibly wrong - watching ~50 TV show episodes that are 4K@60hz HDR could result in 10GiB of GPU memory usage which might cause the GPU process to restart (causing a brief flash as the browser redraws everything) and affects the system negatively overall (other apps may become slower until the GPU process restarts).

An argument could be made for S3 because the user story isn't very common, and the recovery mechanism is completely automatic, and it also has reasonable workarounds (restarting the browser is one option, pressing the Trigger GPU Reset option in about:support is another, and turning off HDR desktop mode is another).

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2037689

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cb19b6d4ac7b
https://hg.mozilla.org/integration/autoland/rev/221f70b5648a
Fix some memory leaks with SavedD3D11State helper class r=gfx-reviewers,gw

Comment 5

[Ashley Hale [:ahale]]

Attachment: Bug 2053263 - Fix some memory leaks with SavedD3D11State helper class

Original Revision: https://phabricator.services.mozilla.com/D310906

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: A GPU memory leak occurs when viewing several HDR videos in a single session. Not fatal - GPU process should recover, but still not a good thing to do in terms of competing with other apps for system resources.
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Low because this refcounting approach is well understood and it is simply fixing a bug that led to excessive retention of resources.
• String changes made/needed?: N/A
• Is Android affected?: no

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/221f70b5648a

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/c08997af273b
https://hg.mozilla.org/releases/mozilla-beta/rev/c889c7cf8e5b

Comment 9

[Ashley Hale [:ahale]]

This doesn't need QA testing, the fix has been verified manually and would not vary by computer.