Open Bug 2053446 Opened 12 days ago Updated 15 hours ago

Fix HCM styles of disabled moz-box-button and panel-list element when Nova is enabled

Categories

(Toolkit :: UI Widgets, defect, P2)

defect

Tracking

()

People

(Reporter: akulyk, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [recomp-nova] [acorntractors])

Attachments

(1 file)

With Nova enabled, --box-button-text-color-disabled (set to --button-text-color-menu-disabled in moz-box.tokens.css) resolves to the ButtonFace color instead of GrayText in HCM. Because of that the text becomes invisible (color of the text is the same as the color of the background).

Whiteboard: [recomp-nova] [acorntractors]

Just a note that panel-list is experiencing the same issue because of how this token resolves. As Jon notes on this patch we need to fix this in Figma for the fix to stick - "For the HCM issue, since this comes from a generated nova tokens file, I think the ultimate fix should be to update button/text/color/menu/disabled to point to button/text/color/disabled in Figma and re-import the tokens."

Summary: Fix HCM styles of the disabled moz-box-button when Nova is enabled → Fix HCM styles of disabled moz-box-button and panel-list element when Nova is enabled
Blocks: 2053913
Severity: -- → S2
Priority: -- → P2

Hey Jules, can we update this token in Figma (Comment 1)?

Flags: needinfo?(jules)

:mstriemer updated it for us last week :)

Flags: needinfo?(jules)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: