2053447 - Implement launch on login for macOS

Status: REOPENED

(Firefox :: Shell Integration, task, P3)

Description

[iain holmes]

Launch on login support is currently only implemented for Windows. it should be possible on macOS

Comment 1

[iain holmes]

Attachment: Bug 2053447 - Part 1: Create a LaunchOnLogin interface for macOS. r=hsohaney,#firefox-desktop-core-reviewers

Implement a macOS interface for adding Login Items (aka LaunchOnLogin) and make a wrapper for LaunchOnLogin that calls the correct OS version.

Comment 2

[iain holmes]

Attachment: Bug 2053447: Part 2 - Port the existing LaunchOnLogin code.r=hsohaney,#firefox-desktop-core-reviewers

Port the WindowsDefaultLaunchOnLogin to use the new generic LaunchOnLogin interface

Comment 3

[iain holmes]

Attachment: Bug 2053447: Part 3 - Update Launch on Login pref to use new API.r=tgiles,mstriemer

Use the new LaunchOnLogin API to determine if LoL is supported and call the correct OS implementation

f3

Comment 4

[iain holmes]

Attachment: Bug 2053447: Part 4 - Update rest of LaunchOnLogin code to use new API.r=#omc-reviewers,#application-update-reviewers,#firefox-desktop-core-reviewers

Port ASRouter and telemetry code to new LaunchOnLogin API

Comment 5

[iain holmes]

Attachment: Bug 2053447: Part 5 - Rename all the windowsLaunchOnLogin prefs.r=hsohaney,#omc-reviewers,#firefox-desktop-core-reviewers

Rename all the windowsLaunchOnLogin preferences to launchOnLogin and upgrade profiles as the feature is no longer Windows only.

Comment 6

[iain holmes]

Attachment: Bug 2053447: Part 5 - Update for enterprise policies.r=hsohaney,mkaply

Update to support the DisableLaunchOnLogin enterprise policy

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2f90071a94c7
https://hg.mozilla.org/integration/autoland/rev/3ad5398abb37
Part 1: Create a LaunchOnLogin interface for macOS. r=hsohaney
https://github.com/mozilla-firefox/firefox/commit/4a2e7ad16021
https://hg.mozilla.org/integration/autoland/rev/dc63d7453f0c
Part 2 - Port the existing LaunchOnLogin code.r=hsohaney
https://github.com/mozilla-firefox/firefox/commit/9f8a694edd7d
https://hg.mozilla.org/integration/autoland/rev/ac434ea20f03
Part 3 - Update Launch on Login pref to use new API.r=tgiles
https://github.com/mozilla-firefox/firefox/commit/07e458f54940
https://hg.mozilla.org/integration/autoland/rev/6044054d2936
Part 4 - Update rest of LaunchOnLogin code to use new API.r=omc-reviewers,firefox-desktop-core-reviewers ,aminomancer
https://github.com/mozilla-firefox/firefox/commit/4e82ceeeb78f
https://hg.mozilla.org/integration/autoland/rev/1802f910a83c
Part 5 - Update for enterprise policies.r=mkaply

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/3ad5398abb37
https://hg.mozilla.org/mozilla-central/rev/dc63d7453f0c
https://hg.mozilla.org/mozilla-central/rev/ac434ea20f03
https://hg.mozilla.org/mozilla-central/rev/6044054d2936
https://hg.mozilla.org/mozilla-central/rev/1802f910a83c

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/17c317251513
https://hg.mozilla.org/integration/autoland/rev/bca44a4f0943
Revert "Bug 2053447: Part 5 - Update for enterprise policies.r=mkaply" for causing bc failures at /browser_suppressTips.js

Comment 10

[Silaghi Andreea]

Backed out for causing bc failures at /browser_suppressTips.js
Backout Link
Push with failures
push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser-tips/suppress-tips/browser_suppressTips.js | updateApplied - updateAppliedTime pref should be updated when booting this test - 0 != 0
TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser-tips/browser_searchTips.js | newtab - Test timed out

Comment 11

[Harshit Sohaney [:hsohaney]]

Hey! i just did a try run for this stack and this failure did not show up - https://treeherder.mozilla.org/jobs?repo=try&revision=d085bbfe64a661a2b5d2381b97dfab29709e87e4&selectedTaskRun=XZqXbC82TZeUDeLntohcGQ.0
am i missing something? the failure looks unrelated to the patches

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6d18ba53d5f9
https://hg.mozilla.org/integration/autoland/rev/544a69b3be17
Part 1: Create a LaunchOnLogin interface for macOS. r=hsohaney
https://github.com/mozilla-firefox/firefox/commit/8df867ed8f7b
https://hg.mozilla.org/integration/autoland/rev/1464cca7523a
Part 2 - Port the existing LaunchOnLogin code.r=hsohaney
https://github.com/mozilla-firefox/firefox/commit/913a5d3241f6
https://hg.mozilla.org/integration/autoland/rev/b1cd88bc52ab
Part 3 - Update Launch on Login pref to use new API.r=tgiles
https://github.com/mozilla-firefox/firefox/commit/0b434d30a1b2
https://hg.mozilla.org/integration/autoland/rev/1ef229f10609
Part 4 - Update rest of LaunchOnLogin code to use new API.r=omc-reviewers,firefox-desktop-core-reviewers ,aminomancer
https://github.com/mozilla-firefox/firefox/commit/b261b48eda5c
https://hg.mozilla.org/integration/autoland/rev/468c79acc5d2
Part 5 - Update for enterprise policies.r=mkaply

Comment 13

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_searchTips.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/adae7962ac50752cca541897a784da097412e26e

Push with failures

Failures log ->TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser-tips/browser_searchTips.js | newtab - Test timed out

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6cee80f87168
https://hg.mozilla.org/mozilla-central/rev/5d8f92a89915
Revert "Bug 2053447: Part 5 - Update for enterprise policies.r=mkaply" for causing bc failures @ browser_searchTips.js

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/544a69b3be17
https://hg.mozilla.org/mozilla-central/rev/1464cca7523a
https://hg.mozilla.org/mozilla-central/rev/b1cd88bc52ab
https://hg.mozilla.org/mozilla-central/rev/1ef229f10609
https://hg.mozilla.org/mozilla-central/rev/468c79acc5d2

Comment 16

[Andrew McCreight [:mccr8]]

FYI, over in bug 2061896, I made a change to WindowsLaunchOnLogin.sys.mjs in the old location. Looking at the git commit, it seems like your move was registered as a move and you didn't change the part of the file that I touched, so hopefully it won't be a problem, but I figured I'd mention it as something to watch out for.

Comment 17

[Iulian Moraru]

Backout merged to central: https://hg-edge.mozilla.org/mozilla-central/rev/adae7962ac50