2053546 - Move browserIcon.ftl strings into preferences.ftl and enable browser.shell.customIcon.enabled by default to ride the trains

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[Mike Conley (:mconley) (:⚙️)]

Once the written copy is signed off, Venetia is hoping we can get the custom browser icon UI turned on to ride the trains.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2053546 - Final copy and style tweaks for custom icon section, moves strings out of preview, and enables the custom icon mechanism by default to ride the trains. r?hjones!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fc452f140fc3
https://hg.mozilla.org/integration/autoland/rev/330b4054ba99
Final copy and style tweaks for custom icon section, moves strings out of preview, and enables the custom icon mechanism by default to ride the trains. r=hjones,fluent-reviewers,flod

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/330b4054ba99

Comment 4

[Francesco Lodolo [:flod]]

The FTL file still has a comment about "preview"

### Preview strings for the custom browser-icon feature (Bug 2049877), which
### will show these strings in about:settings.

We should fix that as soon as someone touches it.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Release Note Request (optional, but appreciated)
[Why is this notable]:

A new capability has been enabled which lets users change the default browser icon on Windows (non-MSIX installs) to some other fun variants.

[Affects Firefox for Android]:

No.

[Suggested wording]:

We've added the ability to let users change the default browser icon in Settings for users on Windows (except for MSIX installs). Support for MSIX installs, macOS and Linux is coming soon.

[Links (documentation, blog post, etc)]:

None.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

I just put in some potential wording there for the Nightly release note, but Venetia, if you've got some better copy, feel free to adjust!

Comment 7

[Mike Conley (:mconley) (:⚙️)]

(In reply to Francesco Lodolo [:flod] from comment #4)

The FTL file still has a comment about "preview"

### Preview strings for the custom browser-icon feature (Bug 2049877), which
### will show these strings in about:settings.

We should fix that as soon as someone touches it.

Thanks! Removing that in bug 2055048.