2053566 - Remove five unused toolkit.telemetry.dap_* preferences

Status: RESOLVED FIXED

(Toolkit :: DAP, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filing as a good first bug to learn workflows.

The following preferences (in modules/libpref/init/all.js) are never read. The DAP feature uses the dot-named prefs (toolkit.telemetry.dap.leader.url, toolkit.telemetry.dap.logLevel, ...) and is gated by the Nimbus dapTelemetry feature; these underscore-named prefs are leftovers. Please remove their definitions.

• toolkit.telemetry.dap_enabled
• toolkit.telemetry.dap_task1_enabled
• toolkit.telemetry.dap_task1_taskid
• toolkit.telemetry.dap_visit_counting_enabled
• toolkit.telemetry.dap_visit_counting_experiment_list

Link to the code:
https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#544

To verify the fix:

• Confirm each pref has no remaining users by searching its name on https://searchfox.org (only the definition should match).
• Build the tree to make sure nothing breaks:
  ./mach build

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Nirmal Advani]

Attachment: Bug 2053566 - Remove unused toolkit.telemetry.dap_* preferences r?Sylvestre

Comment 2

[Nirmal Advani]

The new revision contains my correct author name in git commit.

Comment 3

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:nirmaladvani, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Nirmal Advani]

I don't think I need to do anything here.

Herald added a project: needs-testing-tag. · View Herald TranscriptThu, Jul 23, 6:07 PM
Comment Actions

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Besides, I don't know if it requires testing or not.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

i did it and no need to test

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2a151d9ae396
https://hg.mozilla.org/integration/autoland/rev/92e3fae6cf7a
Remove unused toolkit.telemetry.dap_* preferences r=simonf

Comment 7

[Nirmal Advani]

Thanks

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/92e3fae6cf7a