Closed Bug 2053621 Opened 10 days ago Closed 6 days ago

[wpt-sync] Sync PR 61149 - Don't set test fail status in web-extensions-helper.js.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox154 fixed)

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 61149 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/61149
Details from upstream follow.

justinlulejian <justinlulejian@users.noreply.github.com> wrote:

Don't set test fail status in web-extensions-helper.js.

web-extension-helper.js was overriding the test status to just test.FAIL, leaving out the test message. This causes a test failure to look like: FAIL message: Undefined.UNDEFINED since the message and stack are undefined.

test.set_status(status, message, stack); is already being handled by testharness.js in the step() method (see line 2878) so we can just rely on that.

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b15e95c6c52f https://hg.mozilla.org/integration/autoland/rev/82d02a30a4ef [wpt PR 61149] - Don't set test fail status in web-extensions-helper.js., a=testonly

Test result changes from PR not available.

Status: NEW → RESOLVED
Closed: 6 days ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
You need to log in before you can comment on or make changes to this bug.