Closed Bug 2053651 Opened 10 days ago Closed 6 days ago

[wpt-sync] Sync PR 61163 - [line-clamp] Preserve the `block-ellipsis` state across relayouts

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

Product:
Core
Component:
Layout: Scrolling and Overflow
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
154 Branch
Tracking Flags:
Tracking Status
firefox154 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 61163 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/61163
Details from upstream follow.

Andreu Botella <abotella@igalia.com> wrote:

[line-clamp] Preserve the block-ellipsis state across relayouts

In https://crrev.com/c/7864326, a block_ellipsis field was added to
LineClampData. After https://crrev.com/c/7798861, when
CSSLineClampAsShorthand is disabled, there is no property active at
the inline formatting context where the ellipsis would be placed to
know whether we should place it, so this field stores that state.

However, if there is a relayout (as happens always for
line-clamp: auto if that clamps at all), when the LineClampData
struct in the relayout was being populated, this field was not copied.
This resulted in line-clamp: auto no-ellipsis ignoring the
no-ellipsis keyword in all cases.

Bug: 40336192
Change-Id: Ib11e6b7663442145949aed5ac1029ed85e63db20
Reviewed-on: https://chromium-review.googlesource.com/8064565
WPT-Export-Revision: 4502dfe595cf95ea6ff2c50b460ae0b7d8985a42

Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 267 tests

Status Summary

Firefox

PASS: 6[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 69[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 70[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL: 1[GitHub] 197[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 198[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

https://hg.mozilla.org/mozilla-central/rev/95cf5fa9979b
https://hg.mozilla.org/mozilla-central/rev/e9f245f6783d

Status: NEW → RESOLVED
Closed: 6 days ago
status-firefox154: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
You need to log in before you can comment on or make changes to this bug.