2053717 - Improve immediate materialization for riscv64

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[André Bargull [:anba]]

Improve immediate materialization for riscv64 by importing more code from LLVM's RISCVMatInt file.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 2053717 - Part 1: Remove unused argument from insertEntryForwards. r=#spidermonkey-reviewers!

Comment 2

[André Bargull [:anba]]

Attachment: Bug 2053717 - Part 2: Instruction class changes. r=#spidermonkey-reviewers!

Instruction class changes for later parts:

• IsSlli: Include kFunct6Mask to exclude Zbs instructions which are encoded
  like shift instructions.
• Shamt: Don't allow Imm32 variants.
• SetShamt: Add separate SetShamt32 setter for Imm32 variant.
• SetIShiftFormat, SetIShift32Format: Split from SetIFormat to handle
  shift amount correctly. (Needed for Zbs extension instructions.)
• OpcodeRISCV: Add concept to allow opcodes from extensions.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 2053717 - Part 3: Add InstSeq to avoid duplication in RecursiveLi. r=#spidermonkey-reviewers!

This avoids code duplication and will allow to import more code from LLVM in part 4.

Comment 4

[André Bargull [:anba]]

Attachment: Bug 2053717 - Part 4: Import more code from RISCVMatInt. r=#spidermonkey-reviewers!

Import more code from LLVM's RISCVMatInt file to add extension-specific
optimisations. Also remove Assembler::GeneralLi because it's for the most
redundant with "AssemblerMatInt.cpp".

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f6c38c421928
https://hg.mozilla.org/integration/autoland/rev/e1f8559676a3
Part 1: Remove unused argument from insertEntryForwards. r=spidermonkey-reviewers,jandem
https://github.com/mozilla-firefox/firefox/commit/68f2608ed58a
https://hg.mozilla.org/integration/autoland/rev/637679617ffa
Part 2: Instruction class changes. r=spidermonkey-reviewers,jandem
https://github.com/mozilla-firefox/firefox/commit/69bf07bb2e49
https://hg.mozilla.org/integration/autoland/rev/ca53483b8462
Part 3: Add InstSeq to avoid duplication in RecursiveLi. r=spidermonkey-reviewers,jandem
https://github.com/mozilla-firefox/firefox/commit/5683d6c9747c
https://hg.mozilla.org/integration/autoland/rev/e0662572822c
Part 4: Import more code from RISCVMatInt. r=spidermonkey-reviewers,jandem

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e1f8559676a3
https://hg.mozilla.org/mozilla-central/rev/637679617ffa
https://hg.mozilla.org/mozilla-central/rev/ca53483b8462
https://hg.mozilla.org/mozilla-central/rev/e0662572822c