Closed Bug 2053801 Opened 8 days ago Closed 5 days ago

[wpt-sync] Sync PR 61182 - Add @font-face metric override parsing tests

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox154 fixed)

Status:
RESOLVED FIXED
Milestone:
154 Branch
Tracking Flags:
Tracking Status
firefox154 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 61182 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/61182
Details from upstream follow.

shierote <32413673+shierote@users.noreply.github.com> wrote:

Add @font-face metric override parsing tests

Adds testharness coverage for parsing the CSS Fonts 4 ascent-override,
descent-override, and line-gap-override @font-face descriptors.

The test checks that normal and non-negative percentages are accepted,
and that negative percentages and non-percentage lengths are rejected.

Related WebKit PR: https://github.com/WebKit/WebKit/pull/68736

Tested:
./wpt lint css/css-fonts/parsing/font-face-metric-overrides.html

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 83 tests and 30 subtests

Status Summary

Firefox

OK : 1[GitHub] 83[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 21[GitHub] 1554[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 36

Chrome

OK : 1
PASS: 18
FAIL: 3

Safari

OK : 1
PASS: 6
FAIL: 15

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-fonts/parsing/font-family-computed.html [wpt.fyi]
    • Property font-family value '"New Century Schoolbook", serif': FAIL
  • /css/css-fonts/parsing/font-family-valid.html [wpt.fyi]
    • e.style['font-family'] = ""New Century Schoolbook", serif" should set the property value: FAIL
  • /css/css-fonts/parsing/font-palette-values-valid.html [wpt.fyi]
    • CSS Fonts Module Level 4: parsing @font-palette-values 35: FAIL
  • /css/css-fonts/parsing/font-stretch-alias.html [wpt.fyi]
    • font-stretch is a legacy name alias for font-width: FAIL
  • /css/css-fonts/parsing/font-style-computed.html [wpt.fyi]
    • Property font-style value 'oblique 14deg': FAIL
  • /css/css-fonts/parsing/font-style-valid.html [wpt.fyi]
    • e.style['font-style'] = "oblique 14deg" should set the property value: FAIL
  • /css/css-fonts/parsing/font-width-computed.html [wpt.fyi]
    • Property font-width value 'ultra-condensed': FAIL
    • Property font-width value 'extra-condensed': FAIL
    • Property font-width value 'condensed': FAIL
    • Property font-width value 'semi-condensed': FAIL
    • Property font-width value 'normal': FAIL
    • Property font-width value 'semi-expanded': FAIL
    • Property font-width value 'expanded': FAIL
    • Property font-width value 'extra-expanded': FAIL
    • Property font-width value 'ultra-expanded': FAIL
    • Property font-width value '234.5%': FAIL
    • Property font-width value 'calc(100%)': FAIL
    • Property font-width value 'calc(0%)': FAIL
    • Property font-width value 'calc(-100%)': FAIL
    • Property font-width value 'calc(100% + 100%)': FAIL
    • Property font-width value 'calc(100% + (sign(20cqw - 10px) * 5%))': FAIL
  • /css/css-fonts/parsing/font-width-valid.html [wpt.fyi]
    • e.style['font-width'] = "normal" should set the property value: FAIL
    • e.style['font-width'] = "ultra-condensed" should set the property value: FAIL
    • e.style['font-width'] = "extra-condensed" should set the property value: FAIL
    • e.style['font-width'] = "condensed" should set the property value: FAIL
    • e.style['font-width'] = "semi-condensed" should set the property value: FAIL
    • e.style['font-width'] = "semi-expanded" should set the property value: FAIL
    • e.style['font-width'] = "expanded" should set the property value: FAIL
    • e.style['font-width'] = "extra-expanded" should set the property value: FAIL
    • e.style['font-width'] = "ultra-expanded" should set the property value: FAIL
    • e.style['font-width'] = "234.5%" should set the property value: FAIL
    • e.style['font-width'] = "calc(100%)" should set the property value: FAIL
    • e.style['font-width'] = "calc(0%)" should set the property value: FAIL
    • e.style['font-width'] = "calc(-100%)" should set the property value: FAIL
    • e.style['font-width'] = "calc(100% + 100%)" should set the property value: FAIL
    • e.style['font-width'] = "calc(100% + (sign(20cqw - 10px) * 5%))" should set the property value: FAIL

https://hg.mozilla.org/mozilla-central/rev/26c4af07e717

Status: NEW → RESOLVED
Closed: 5 days ago
status-firefox154: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
You need to log in before you can comment on or make changes to this bug.