Closed Bug 2053809 Opened 8 days ago Closed 5 days ago

[wpt-sync] Sync PR 61183 - Propagate block-end annotation space from previous sibling block

Categories

(Core :: Layout: Ruby, task, P4)

task

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 61183 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/61183
Details from upstream follow.

Kent Tamura <tkent@chromium.org> wrote:

Propagate block-end annotation space from previous sibling block

When laying out a block container, if it has no block-end border and not
a new formatting context, propagate its last line's block-end annotation
space to its layout result.

During layout of subsequent sibling blocks, this space is retrieved from
the constraint space and added to the initial block-start annotation
space to allow ruby annotations to overlap.

This CL extends ConstraintSpace to carry the previous sibling's
block-end annotation space, and propagates them in BlockLayoutAlgorithm.
This CL also moves block_start_annotation_space from RareData to
BlockData.

WPT:
Update some tests to avoid shorter block-gap, by adding
overflow: hidden, which creates a new formatting context.

DesignDoc: https://docs.google.com/document/d/1h1jTJLXHcdMdFUIgMRxkFEJQ3wQ86Ru38sMA9r51pEw/edit?usp=sharing

Bug: 445727139
Change-Id: I52dd0c401883668225ceadf310146261e6c6267d
Reviewed-on: https://chromium-review.googlesource.com/8000812
WPT-Export-Revision: 498ea4d17794d14b8ac3058cee82f9797d49eb39

Component: web-platform-tests → Layout: Ruby
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1279 tests and 2 subtests

Status Summary

Firefox

OK : 134
PASS : 1[GitHub] 12[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1858[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 2895[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 2907[Gecko-windows11-64-25h2-opt] 2908[Gecko-windows11-64-25h2-debug] 2909[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL : 4[GitHub] 172[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 253[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 254[Gecko-windows11-64-25h2-debug] 255[Gecko-windows11-64-25h2-opt] 267[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
ERROR: 1

Chrome

PASS : 4
FAIL : 1

Safari

FAIL : 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 5 days ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
You need to log in before you can comment on or make changes to this bug.