2053824 - Migrate History.fetchMany chunked IN-clause queries to array binding

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[CalebChan]

As part of the leftover-inventory audit in bug 2042102 (blocking meta bug 2042084 "Replace IN clauses with array bindings in Places"), History.fetchMany's inner implementation (toolkit/components/places/History.sys.mjs, fetchMany) still chunks its guidOrURLs input via PlacesUtils.chunkArray(guidOrURLs, db.variableLimit) and builds url_hash IN(hash(?),...), url IN(?,...), and guid IN(?,...) clauses via PlacesUtils.sqlBindPlaceholders before running a SELECT against moz_places.

This should be migrated to use Sqlite.sys.mjs array binding (added in bug 1924124) instead of manual chunking + IN(?,?,?) placeholder lists, following the pattern used in the already-landed sibling bugs (2042085, 2042088-2042097).

Comment 1

[CalebChan]

Attachment: Bug 2053824 - Migrated fetchMany to array binding. r=mak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/88bb3924016e
https://hg.mozilla.org/integration/autoland/rev/5adb96507633
Migrated fetchMany to array binding. r=mak,places-reviewers

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5adb96507633