Closed Bug 2053825 Opened 2 months ago Closed 1 month ago

Migrate PlacesSyncUtils.determineNonSyncableGuids chunked IN-clause query to array binding

Categories

(Toolkit :: Places, task, P3)

Product:
Toolkit
Component:
Places
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
155 Branch
Tracking Flags:
Tracking Status
firefox155 --- fixed

People

(Reporter: cachan, Assigned: cachan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng])

Attachments

(1 file)

Bug 2053825 - Migrated determineNonSyncableGuids to array binding. r=mak
48 bytes, text/x-phabricator-request
Details | Review

Follow-up from the leftover-inventory audit in bug 2042102 (blocking meta bug 2042084). PlacesSyncUtils.determineNonSyncableGuids (toolkit/components/places/PlacesSyncUtils.sys.mjs) chunks its guids input via PlacesUtils.chunkArray(guids, db.variableLimit) and manually builds a p.guid IN (?,?,...) clause for a query joining moz_places and moz_historyvisits.

Should be migrated to Sqlite.sys.mjs array binding (bug 1924124) instead of chunking + manual placeholder lists, following the pattern from already-landed sibling bugs.

Priority: -- → P3
Whiteboard: [sng]
Assignee: nobody → cachan
Pushed by cachan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0bc38be784b5 https://hg.mozilla.org/integration/autoland/rev/f679cbabeb0a Migrated determineNonSyncableGuids to array binding. r=mak,places-reviewers

https://hg.mozilla.org/mozilla-central/rev/f679cbabeb0a

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox155: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
QA Whiteboard: [qa-triage-done-c156/b155]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: