2053826 - Migrate BookmarkList#fetchTrackedUrls chunked IN-clause query to array binding

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[CalebChan]

Follow-up from the leftover-inventory audit in bug 2042102 (blocking meta bug 2042084). BookmarkList#fetchTrackedUrls (toolkit/components/places/BookmarkList.sys.mjs) chunks its urls input via PlacesUtils.chunkArray(urls, db.variableLimit) and manually builds a p.url_hash IN (?,?,...) clause (Array(chunk.length).fill("?").join(",")) for a query joining moz_bookmarks and moz_places.

Should be migrated to Sqlite.sys.mjs array binding (bug 1924124) instead of chunking + manual placeholder lists, following the pattern from already-landed sibling bugs.

Comment 1

[CalebChan]

Attachment: Bug 2053826 - migrating fetchTrackedURLs to array binding. r=mak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a19eb773c2c8
https://hg.mozilla.org/integration/autoland/rev/b94cf8c6f4f5
migrating fetchTrackedURLs to array binding. r=mak,places-reviewers

Comment 3

[rperta]

https://hg.mozilla.org/mozilla-central/rev/b94cf8c6f4f5