2054029 - Settings dialog close buttons looks odd on hover

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Attachment: hovered close button

When Nova is enabled, hovering the close button reveals that it's not a circle and the icon is not centered

Comment 1

[Stuart Colville [:muffinresearch]]

To get to see the dialog above:

• Nova should be enabled.
• Open settings passwords and autofill about:preferences#passwordsAutofill
• Make sure "Save and autofill addresses" is checked
• Click on "Manage addresses and more"
• Click Add address

Comment 2

[akulyk]

Probably we should use moz-button type ghost for Close dialog button

Comment 3

[Mark Striemer [:mstriemer]]

These should all come from the dialog template in preferences.xhtml, and it isn't specific to the add address dialog, it's all preferences dialogs

Comment 4

[Mark Kennedy [:mark]]

Attachment: Bug 2054029 - Use moz-button ghost for the preferences dialog close button r=#reusable-components-reviewers-rotation

This changes the preferences sub-dialog close button to use the standard ghost button, so its hover state matches the rest of the design system.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/58bd4c92ab1f
https://hg.mozilla.org/integration/autoland/rev/93f022f82ace
Use moz-button ghost for the preferences dialog close button r=akulyk,kcochrane

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/93f022f82ace

Comment 7

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in Nightly 155.0a1(2026-08-13).