2054110 - [IPC Urlbar] Route speculative connect over the actor message path

Status: ASSIGNED

(Firefox :: Address Bar, task)

Description

[Dão Gottwald [:dao]]

Broken out from Bug 2051959.

Route the urlbar's speculative connection over the actor message path, resolving the window parent-side from the actor, so it works when the controller runs across the boundary.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 2054110 - [IPC Urlbar] Route speculative connect over the actor message path. r?mbeier!

UrlbarChildController.speculativeConnect (from the view on mousedown, and for
the heuristic result when the first results arrive) forwarded to
this.#parent.speculativeConnect, which the message-path proxy didn't
implement, so it threw over the wire. Add a SpeculativeConnect C->P message and
the matching proxy method, serializing the result and context like the other
query messages.

The recording needs the chrome window, which the parent resolves from the actor,
so the guard keys on browserWindow rather than input (null on the message
path).

The heuristic ("resultsadded") request now fires content-side from
UrlbarChildController when the first results arrive, rather than parent-side
from receiveResults, so it runs identically on both paths (the parent has
already let the input react to the first result before notifying).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3f740e95d82d
https://hg.mozilla.org/integration/autoland/rev/ae7ea628c71a
[IPC Urlbar] Route speculative connect over the actor message path. r=mbeier