2054228 - Use new color syntax throughout the DevTools

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Sebastian Zartner [:sebo]]

The CSS used within the DevTools still mostly uses the legacy comma-separated syntax for color values. It should be changed to the newer space/slash-separated syntax to be future-proof and to encourage modern CSS.

This mostly affects CSS files, of course, though there are also a few JS, SVG, and HTML files that should be updated.

Note that colors defined using the new syntax still compute to the legacy syntax for compatibility reasons. So any tests or other JS checking the computed values must continue to use the old syntax.

Sebastian

Comment 1

[Samuel Mbabhazi]

I have a patch ready that converts the CSS files and the shipped themed SVG icons. Test fixtures, the vendored CodeMirror files and the docs diagrams are deliberately left out, and the JS occurrences are mostly computed-value assertions in tests, so those would be a follow-up. Could you assign this to me? I will submit the patch right away.

Comment 2

[Samuel Mbabhazi]

Attachment: Bug 2054228 - Use the modern space-separated color syntax in DevTools stylesheets and themed SVGs. r=#devtools-reviewers

Convert the legacy comma-separated rgb()/rgba()/hsl()/hsla() notation to the
modern space and slash separated syntax in DevTools CSS files and in the
shipped themed SVG icons. Every converted value is numerically identical to
the original.

Deliberately left unchanged: test fixtures and expectations (computed values
still serialize to the legacy syntax), the vendored CodeMirror stylesheets,
and the contributor docs diagrams. The remaining occurrences in JS files can
be handled in a follow-up, since most of them are computed-value assertions
in tests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7493f8317675
https://hg.mozilla.org/integration/autoland/rev/fd35276941b9
Use the modern space-separated color syntax in DevTools stylesheets and themed SVGs. r=devtools-reviewers,bomsy

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fd35276941b9