2054311 - Sort more headers automatically.

Status: ASSIGNED

(Core :: General, enhancement, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

dom/ and layout/ already sort headers automatically, let's make that the default, as per our coding style.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Sort includes in media/. r=#media-playback-reviewers

Automatically generated with:

cp dom/.clang-format media/ && mach format media/**.{cpp,h}

No manual changes required.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Sort headers in xpcom/. r=#xpcom-reviewers

Automatically generated with:

cp dom/.clang-format xpcom/ && mach format xpcom/**.{cpp,h}

No manual changes required.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Sort headers in widget/. r=stransky,#win-reviewers

Autogenerated with:

cp dom/.clang-format widget/ && mach format widget/**.{cpp,h,mm}

Manual changes:

• Had to add a manual override in nsWaylandDisplay.h.
• Missing includes in nsWindowWayland/X11.h

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Sort headers in caps/. r=evilpie,freddyb

Autogenerated with:

cp dom/.clang-format caps/ && mach format caps/**.{cpp,h}

No manual changes required.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Sort includes in security/. r=evilpie,freddyb

Autogenerated with:

cp dom/.clang-format security/ && mach format security/**.{cpp,h,mm}

Manual changes:

• Missing includes in CRLiteTimestamp.h and AppSignatureVerification.h

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Sort includes in mfbt. r=sergesanspaille

Autogenerated with:

cp dom/.clang-format mfbt/ && mach format mfbt/**.{cpp,h,mm}

No manual changes required.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Sort includes in accessible/. r=#accessibility-platform-reviewers

Autogenerated with:

cp dom/.clang-format accessible/ && mach format accessible/**.{cpp,h,mm}

Manual fixes:

• Atk individual includes need to become atk/atk.h because otherwise some symbols incorrectly get hidden visibility.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Sort includes in image/. r=aosmond,tnikkel

Autogenerated by:

cp dom/.clang-format image/ && mach format image/**.{cpp,h,mm}

No manual changes required.

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Add osvr to ThirdPartyPaths. r=#gfx-reviewers

It seems third-party (https://osvr.github.io/). This prevent the
following commit from rewriting those.

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw

Autogenerated with:

cp dom/.clang-format gfx/ && mach format gfx/**.{cpp,h,mm}

Only manual change in OSVRSession since OSVR headers are not system
headers and they are not standalone / rely on stdint.

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Sort headers in netwerk/. r=#necko-reviewers

Autogenerated with:

cp dom/.clang-format netwerk/ && mach format netwerk/**.{cpp,h,mm}

Manual fixes in:

• mozurl/cbindgen.toml (including headers earlier)
• NetlinkService.h (forward-declaring a necessary struct)
• nsIWebSocketChannel.idl (forward-declaring OriginAttributes).
• nsAsyncRedirectVerifyHelper.h (forward-declaring nsIEventTarget)

Comment 12

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Use .clang-format rather than check_spidermonkey_style to sort spidermonkey headers. r=#spidermonkey-reviewers

Note that this is probably a bit controversial maybe because of
check_spidermonkey_style changes, see above. I think standardizing on
the same order as the rest of Gecko probably makes sense tho.

Autogenerated with:

cp dom/.clang-format js/ && mach format js/**.{cpp,h,mm}

Manual fixes:

* Make check_spidermonkey_style not check itself for order, since
  the order doesn't match clang-format's.
* Missing include in WasmBCClass-inl.h

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fdebe04602b2
https://hg.mozilla.org/integration/autoland/rev/7728a8e24233
Sort includes in image/. r=tnikkel

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/05deca67778c
https://hg.mozilla.org/integration/autoland/rev/3e2330281cc6
Sort includes in media/. r=webrtc-reviewers,mjf

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/30668817f15d
https://hg.mozilla.org/integration/autoland/rev/e759e101a03d
Revert "Bug 2054311 - Sort includes in media/. r=webrtc-reviewers,mjf" for causing build bustage

Comment 16

[rperta]

Backed out for causing build bustage
Backout link
Push with failures
Failure log(s)

Comment 17

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Add a missing include in OriginOperations.cpp. r=janv

AssertNoOverflow is defined in that header. This fixes non-unified build
issues locally on windows.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a9e167956284
https://hg.mozilla.org/integration/autoland/rev/1fdab388a096
Add a missing include in OriginOperations.cpp. r=janv

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/107d4eb7377d
https://hg.mozilla.org/integration/autoland/rev/684f6f540186
Sort includes in media/. r=webrtc-reviewers,mjf

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/af3917c51920
https://hg.mozilla.org/integration/autoland/rev/bb3ff80f3c26
Add osvr to ThirdPartyPaths. r=gfx-reviewers,gw
https://github.com/mozilla-firefox/firefox/commit/a440136b1d9e
https://hg.mozilla.org/integration/autoland/rev/455c572cb1e0
Sort includes in gfx/. r=gfx-reviewers,gw

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4408fe95bc97
https://hg.mozilla.org/integration/autoland/rev/c447a83d41c9
Revert "Bug 2054311 - Sort includes in gfx/. r=gfx-reviewers,gw" for causing build bustages @ MockScaledFont.h

Comment 22

[pstanciu]

Backed out for causing build bustages @ MockScaledFont.h

• https://hg.mozilla.org/integration/autoland/rev/c447a83d41c905057d1556d5985a0b8689992de3
• Push with failures
• Failure Log

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/24211cd4e287
https://hg.mozilla.org/integration/autoland/rev/f100a12930c6
Sort includes in accessible/. r=accessibility-platform-reviewers,Jamie

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/abee94d1b669
https://hg.mozilla.org/integration/autoland/rev/0a9bc5b72fa1
Add osvr to ThirdPartyPaths. r=gfx-reviewers,gw

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/02d691fdefd6
https://hg.mozilla.org/integration/autoland/rev/642cefd81bda
Sort includes in gfx/. r=gfx-reviewers,gw

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/abbeff4fd9e0
https://hg.mozilla.org/integration/autoland/rev/f8a9b6077049
Sort headers in netwerk/. r=webrtc-reviewers,cookie-reviewers,mjf,timhuang

Comment 27

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2054311 - Reformat js/ after the previous change. r=#spidermonkey-reviewers

See the previous commit for details.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c33f976fda3e
https://hg.mozilla.org/integration/autoland/rev/5553bd66afda
Sort headers in caps/. r=tschuster

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2223a8bee297
https://hg.mozilla.org/integration/autoland/rev/f4d9330d4f7b
Sort headers in xpcom/. r=xpcom-reviewers,nika

Comment 30

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f100a12930c6
https://hg.mozilla.org/mozilla-central/rev/0a9bc5b72fa1
https://hg.mozilla.org/mozilla-central/rev/642cefd81bda
https://hg.mozilla.org/mozilla-central/rev/f8a9b6077049
https://hg.mozilla.org/mozilla-central/rev/5553bd66afda

Comment 31

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f4d9330d4f7b

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2861287f6dc1
https://hg.mozilla.org/integration/autoland/rev/5feb91ff8161
Sort headers in widget/. r=stransky,win-reviewers,geckoview-reviewers,gstoll,owlish

Comment 33

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5feb91ff8161

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7c43dd397a32
https://hg.mozilla.org/integration/autoland/rev/e832c7354db9
Use .clang-format rather than check_spidermonkey_style to sort spidermonkey headers. r=spidermonkey-reviewers,jandem
https://github.com/mozilla-firefox/firefox/commit/934b0109fd73
https://hg.mozilla.org/integration/autoland/rev/2483136b0ecf
Reformat js/ after the previous change. r=spidermonkey-reviewers,jandem

Comment 35

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e832c7354db9
https://hg.mozilla.org/mozilla-central/rev/2483136b0ecf

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c785e028f9a3
https://hg.mozilla.org/integration/autoland/rev/13ea98999034
Sort includes in security/. r=sandbox-reviewers,keeler,bobowen,jld

Comment 37

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/13ea98999034