2054385 - Body search fails in quoted-printable with trailing equals

Status: RESOLVED FIXED

(MailNews Core :: Search, defect)

Description

[Francesco (no longer active, use PM for contact)]

Attachment: test-html-qp.eml

STR:
Load message into TB, use QuickFilter, look for word "found" in body.

Not found using TB 140 or also beta.

I came across this in the wild and boiled it down to the trailing = at the and of the message.

Comment 1

[Wayne Mery (:wsmwk)]

Please avoid using abbreviations in bug summaries (and in general) - it hurts both user and developer searching. In this case, quoted-printable is most frequently used form in bugzilla. Thanks.

Comment 2

[Wayne Mery (:wsmwk)]

I took a spin through "QP" https://mzl.la/454HeON - I think the first one is a duplicate of this?

Comment 3

[Francesco (no longer active, use PM for contact)]

You mean bug 113120? Maybe vaguely related. The message is displayed fine, however, the search just fails. Unfortunately, this particular sender always has a trailing = at the end.

The error is likely around here:
https://searchfox.org/comm-central/rev/72b8ba0761b3881d926be53f77fbf75d5a9316d5/mailnews/search/src/nsMsgSearchTerm.cpp#821

Note that this
https://searchfox.org/comm-central/rev/72b8ba0761b3881d926be53f77fbf75d5a9316d5/mailnews/search/src/nsMsgBodyHandler.cpp#694
is only called for search in PGP or S/MIME messages (since GetRelevantTextParts() is only called for those messages).

Comment 4

[Wayne Mery (:wsmwk)]

Yes, that one - I read it too quickly

Comment 5

[Max Emig [:maxe]]

Attachment: Bug 2054385 - Fix body search for quoted-printable messages ending on a soft line break. r=#thunderbird-back-end-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8465a67db60d
Fix body search for quoted-printable messages ending on a soft line break. r=tobyp