2054428 - view-source:blob doesn't work

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Vincent Hilla [:vhilla]]

Attachment: test.html

STR

Open a blob URL, right click, view page source.

Nightly and Chrome refuse to load. Nightly states "Hmm. That address doesn’t look right." and "Nightly can’t connect to the server at (data)".

Release does succeed in showing source.

Mozregression

1:56.34 INFO: Last good revision: c3ced093061480f46d51b9b7028ec647c6af5c14
1:56.34 INFO: First bad revision: 931e624c6f53269d41e57ecefca418ef7fdb0f75
1:56.34 INFO: Pushlog:
https://hg.mozilla.org/releases/mozilla-release/pushloghtml?fromchange=c3ced093061480f46d51b9b7028ec647c6af5c14&tochange=931e624c6f53269d41e57ecefca418ef7fdb0f75

Comment 1

[Vincent Hilla [:vhilla]]

I'm guessing bug 2005002. Found this while doing manual tests for bug 2048851.

Perhaps this can be wontfix given Chrome also won't show blob source.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2005002

:nika, since you are the author of the regressor, bug 2005002, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 2054428 - Correctly unwrap url for blob principals, r=asuth!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/720095bf6161
https://hg.mozilla.org/integration/autoland/rev/6ef9e54cd844
Correctly unwrap url for blob principals, r=asuth

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6ef9e54cd844

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:nika, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox153 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: view-source on a blob: URL does not properly work.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Small change to principal creation code to restore behaviour, enabling view-source: to work.
• String changes made/needed?: None
• Is Android affected?: yes

Comment 8

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 2054428 - Correctly unwrap url for blob principals,

Original Revision: https://phabricator.services.mozilla.com/D311846

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9609182 [details]
Bug 2054428 - Correctly unwrap url for blob principals,

Moving request to release

Comment 10

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2005002

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/7028f59d2a25
https://hg.mozilla.org/releases/mozilla-release/rev/610ef08ce666

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr153/rev/4d0a51a14b55