2054477 - Update AboutWelcome default screens based on pin prompt segmentation and trigger auto pinning when OS-level consent prompt will show

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar]

Update AboutWelcome defaults to not show the pin option on Windows builds that support showing an OS-level user consent prompt for pinning. Use an action_only message to trigger pinning for these users instead. Also, add a targeting constant using Windows build / UBR for whether or not a user will see an OS-level pin consent prompt when pinning is triggered.

Comment 1

[Meg Viar]

Attachment: Bug 2054477 - Update AboutWelcome default screens based on pin prompt segmentation

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/845af8cb8302
https://hg.mozilla.org/integration/autoland/rev/4c9ce1c3085d
Update AboutWelcome default screens based on pin prompt segmentation r=omc-reviewers,jprickett

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/39b2f727cc64
https://hg.mozilla.org/integration/autoland/rev/7d87a369f973
Revert "Bug 2054477 - Update AboutWelcome default screens based on pin prompt segmentation r=omc-reviewers,jprickett" for causing xpcshell failures on test_OnboardingMessageProvider.js.

Comment 5

[Iulian Moraru]

Revert for causing xpcshell failures on test_OnboardingMessageProvider.js.

• Push with failures

• Failure log

• Backout link

LATER EDIT: we also found that it caused these eme job failures: https://treeherder.mozilla.org/logviewer?job_id=578720976&repo=autoland&task=C4BhyVTWSTC82OGLqhOa7w.0&lineNumber=5945

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/31e261f2af99
https://hg.mozilla.org/integration/autoland/rev/14022915baf4
Update AboutWelcome default screens based on pin prompt segmentation r=omc-reviewers,jprickett

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/455dd5e8dbe5
https://hg.mozilla.org/integration/autoland/rev/d3df75ed7b26
Revert "Bug 2054477 - Update AboutWelcome default screens based on pin prompt segmentation r=omc-reviewers,jprickett" for causing wpt failures.

Comment 8

[Serban Stanca [:SerbanS]]

Reverted this because it was causing wpt failures.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | leakcheck large nsGlobalWindowInner | /encrypted-media

Please also check these wd failures.

Comment 9

[Meg Viar]

(In reply to Serban Stanca [:SerbanS] from comment #8)

Reverted this because it was causing wpt failures.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | leakcheck large nsGlobalWindowInner | /encrypted-media

Please also check these wd failures.

Thanks for flagging, I didn't see this issue in my try run. I've updated the patch to gate auto-firing the pin action in automation and am re-running the failing jobs on try.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6aff854d9653
https://hg.mozilla.org/integration/autoland/rev/1ab252154cab
Update AboutWelcome default screens based on pin prompt segmentation r=omc-reviewers,jprickett

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1ab252154cab

Comment 12

[Performance Sheriff Bot]

Perfherder has detected a browsertime performance change from push 1ab252154cab21afed20d53196a2d8c370377817.

No action is required from the author; this comment is provided for informational purposes only.

Improvement	Test	Platform	Options	Absolute values [old vs new]	Performance Profiles
6%	welcome LastVisualChange (doc)	windows11-64-24h2-shippable	fission warm webrender	2,132.84 ms -> 1,999.88 ms	Before/After
6%	welcome LastVisualChange (doc)	windows11-64-24h2-shippable	cold fission webrender	2,126.55 ms -> 1,995.22 ms	Before/After

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 14

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this enhancement using the latest Firefox Nightly 155.0a1 (Build ID: 20260812080401) and Firefox Beta 154.0b10 (Build ID: 20260720195614) builds on Windows 10 x64, macOS 15.7.3, and Ubuntu 24.04.1.

• I confirm the following:
  • For builds that do NOT show an OS‑level pin prompt:
  • The OS‑level pin prompt doesn’t appear as expected when the pin action is triggered.
  • The “Easy Setup” screen still shows both the pin checkbox and the default‑browser checkbox, with no changes in behavior. (except on Linux OS where the pin feature is not supported)
  • For builds that DO show an OS‑level pin prompt:
  • The OS‑level pin prompt appears as expected when the pin action is triggered.
  • After accepting it, Firefox is correctly pinned.
  • After unpinning Firefox and restarting the browser with the same profile, I confirm that it does not automatically re‑pin itself and the OS‑level prompt does not appear again.
  • The pin checkbox is no longer shown on the “Easy Setup” screen and the default‑browser checkbox remains visible.
  • Existing‑user check (for builds that DO show the OS‑level pin prompt):
  • Using an already‑used profile where Firefox was unpinned, I restarted Firefox and confirm that it does not silently re‑pin itself. The new behavior only triggers on a genuinely new profile’s first startup.