2054548 - aboutaddons-themes-picker webcomponent should account for download/install failures of the Nova Themes hosted on AMO

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As a followup to Bug 2051571, which will be introducing a new aboutaddons-themes-picker webcomponent for the Firefox themes moz-card grid of Nova theme cards, the new webcomponent should account for edge cases that would trigger a download or install failure (e.g. the XPI url for the Nova themes hosted on AMO would fail to be resolved if the Firefox instance can't reach the AMO service when there isn't an internet connection, or the theme may fail to be installed due to disk failures or not enough free space in the filesystem where the user profile is located).

This followup is tracking work on the additional change to handle these error scenario explicitly (e.g. by showing an error message bar to make the user aware that an error was hit and the Nova theme hosted on AMO couldn't be enabled due to that), instead of failing silently.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 2054548 - Make sure ThemesList.sys.mjs handle gracefully AMO-hosted theme install failures. r?willdurand

Depends on D312804

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 2054548 - Add a moz-messagebar to be shown on addons-themes-picker install errors. r?willdurand

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e93107a188c9
https://hg.mozilla.org/integration/autoland/rev/90cb1ac0aaa1
Make sure ThemesList.sys.mjs handle gracefully AMO-hosted theme install failures. r=willdurand,desktop-theme-reviewers,hjones
https://github.com/mozilla-firefox/firefox/commit/82d29f8c940f
https://hg.mozilla.org/integration/autoland/rev/7ed6a8a8dfc9
Add a moz-messagebar to be shown on addons-themes-picker install errors. r=willdurand,fluent-reviewers,bolsson

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/90cb1ac0aaa1
https://hg.mozilla.org/mozilla-central/rev/7ed6a8a8dfc9