2054781 - browser_884402_customize_from_overflow.js times out when Nova is enabled

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Stephen Thompson [:sthompson]]

browser/components/customizableui/test/browser_884402_customize_from_overflow.js fails with "Test timed out" on Nova Tier-3 test runs, across all platforms.

Dashboard: https://tests.firefox.dev/test.html?test=browser/components/customizableui/test/browser_884402_customize_from_overflow.js

Times out at https://searchfox.org/firefox-main/source/browser/components/customizableui/test/browser_884402_customize_from_overflow.js#61 so probably the synthetic mouse event is not hitting the FxA account button

Comment 1

[Stephen Thompson [:sthompson]]

Although this test fails intermittently https://bugzilla.mozilla.org/show_bug.cgi?id=2039213 there is a Nova-specific regression

Comment 2

[Stephen Thompson [:sthompson]]

Attachment: Bug 2054781 - fix Nova failure for browser_884402_customize_from_overflow.js r=sfoster

Make the test click the center of the element instead of at (2,2).

Proton --panel-menuitem-border-radius is 4px but Nova is 16px. The position (2,2) does not overlap the toolbarbutton background when the border-radius is high. Instead of hardcoding a more comfortable position, I figured it's fine to click the element's center.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e8dafa065d67
https://hg.mozilla.org/integration/autoland/rev/6f8814bd2b59
fix Nova failure for browser_884402_customize_from_overflow.js r=sfoster

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/6f8814bd2b59