2054885 - Introduce "Use Linux system theme" checkbox to the default theme card

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

Per UX specs, the active theme card should provide a "Use Linux system theme" checkbox on the default theme active theme card (see figma design here).

This bugzilla issue is tracking the work on the additional changes to provide that additional control to the user when Nova is enabled.

Comment 1

[zlice]

lmk if i should open another bug but..

just restarted nightly and have the default purple-orange gradient theme. firefox isn't using my gtk default theme. private theme was already botched a bit back and wouldn't obey turning off the purple stain on every empty page.

no about:config settings stand out. is there a way to change this or is it just a nightly push that will get undone? or wait for this bug to allow system theme?

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to zlice from comment #1)

lmk if i should open another bug but..

just restarted nightly and have the default purple-orange gradient theme. firefox isn't using my gtk default theme. private theme was already botched a bit back and wouldn't obey turning off the purple stain on every empty page.

no about:config settings stand out. is there a way to change this or is it just a nightly push that will get undone? or wait for this bug to allow system theme?

The about:config pref that should be controlling the use of the Linux GTK colors when the default theme is enabled is browser.theme.native-theme, it should be true by default for Linux builds (enabled by default here in Firefox builds when MOZ_WIDGET_GTK is defined).

You could take a look from about:config to confirm if browser.theme.native-theme is already set to true for you as expected (and try to set it to true if it is not).

This bugzilla issue is specifically tracking exposing the state of the underlying browser.theme.native-theme pref in the about:addons page, but the underlying feature should work independently from this bug.

And so, if the GTK accent color doesn't seem to be used for you while browser.theme.native-theme is set to true and the currently active theme is the Default theme, a new bug filed in the "Firefox :: Theme" component would be better to make sure it gets to the right engineers (the ones more knowledgeable about that part) asap so that they can investigate it further.

You can file a new bug in that component by following this link: https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox&component=Theme

As a side note, in the new filed bug it may be helpful to also attach in the newly filed bug the details gathered from about:support, because it may provide some more details about your setup that would help with investigating the underlying issue.

In the meantime, thank you a lot for bringing that up as soon as you noticed an issue with the new theme and the gtk theme colors.

Comment 3

[zlice]

thanks, sounds like i'll make a new bug in that case (it is set to true)

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 2054885 - Introduce 'Use Linux system theme' checkbox to the default theme card in about:addons. r?willdurand!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/31c839d3fbc0
https://hg.mozilla.org/integration/autoland/rev/414672fb3624
Introduce 'Use Linux system theme' checkbox to the default theme card in about:addons. r=willdurand,fluent-reviewers,bolsson

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/414672fb3624