2055119 - [Nova] Incorrect margin block of tabs in compact mode

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Merci chao]

It should be --tab-margin-block:

  @media -moz-pref("browser.nova.enabled") {
    &[uidensity="compact"] {
      --tab-block-margin: 4px;
    }
  }

Comment 1

[Stephen Thompson [:sthompson]]

--tab-block-margin was a local CSS property that we used in tabs.css.

--tab-margin-block is a local design token https://searchfox.org/firefox-main/search?q=--tab-margin-block&path=&case=true&regexp=false introduced more recently.

Looks like bug 2030953 used the old --tab-block-margin name for new code. We should use --tab-margin-block and make sure compact mode still looks correct.

Comment 2

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 2055119 - Switch --tab-block-margin to --tab-margin-block in tabs.css

Comment 3

[Merci chao]

Please note that the gUIDensity.AUTO_COMPACT_REFERENCE_TABSTRIP_HEIGHT also needs to be updated. It should be 28 + 4 * 2 = 36, not 40, which is based on the wrong margin value.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e0c09cc29cb8
https://hg.mozilla.org/integration/autoland/rev/c1aa2d77fca3
Switch --tab-block-margin to --tab-margin-block in tabs.css r=desktop-theme-reviewers,tabbrowser-reviewers,jswinarton,Itiel

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c1aa2d77fca3