Closed
Bug 2055123
Opened 4 months ago
Closed 4 months ago
rungtests.py only runs test suites until the first failure is encountered
Categories
(Testing :: GTest, defect)
Testing
GTest
Tracking
(firefox154 fixed)
RESOLVED
FIXED
154 Branch
| Tracking | Status | |
|---|---|---|
| firefox154 | --- | fixed |
People
(Reporter: jschanck, Assigned: jschanck)
References
Details
Attachments
(1 external file)
Perfherder graphs for a number of platform benchmarks have not accumulated fresh data on macosx1500-aarch64-shippable since ~June 18 (e.g. BenchEncrypt_AES_GCM_128m). I think this is because (1) rungtests.py uses a short-circuiting generator expression here, and (2) Bug 2053103 causes a failure before the BenchEncrypt_AES_GCM_128m test runs.
Since a gtest can output perfherder data as a side-effect, we should always run all test suites.
| Assignee | ||
Comment 1•4 months ago
|
||
Comment 2•4 months ago
|
||
The following patch is waiting for review from an inactive reviewer:
| ID | Title | Author | Reviewer Status |
|---|---|---|---|
| D312214 | Bug 2055123 - avoid short-circuiting test suite evaluation in rungtests.py. r?jmaher | jschanck | jmaher: Inactive |
:jschanck, could you please find another reviewer?
For more information, please visit BugBot documentation.
Flags: needinfo?(jschanck)
| Assignee | ||
Updated•4 months ago
|
Flags: needinfo?(jschanck)
Updated•4 months ago
|
Attachment #9609051 -
Attachment description: Bug 2055123 - avoid short-circuiting test suite evaluation in rungtests.py. r?jmaher → Bug 2055123 - avoid short-circuiting test suite evaluation in rungtests.py. r?ahal
Pushed by jschanck@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/0203f4f04b6a
https://hg.mozilla.org/integration/autoland/rev/ac66ac48f2a6
avoid short-circuiting test suite evaluation in rungtests.py. r=ahal
Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox154:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•