2055372 - [text-box-trim] Fix font baseline selection for `text` edge

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Sajid Anwar [:sajidanwar]]

See Bug 2050141 (and specifically, Sebastian's comment, my comment, and the attached test case). The text edge is supposed to use the text-over and text-under baselines, which in Firefox and other browsers is based on the max ascent and descent of the inline box's font. But my implementation instead selected the "trimmed" ascent and descent (ref), which additionally subtract the "internal leading" of the font (if any). This makes Firefox trim too far on certain fonts as can be seen in the test case on the other bug.

Comment 1

[Sajid Anwar [:sajidanwar]]

Attachment: Bug 2055372 - Fix font baseline selection for text-box-edge: text. r=#layout-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4534c066356f
https://hg.mozilla.org/integration/autoland/rev/b284ec0aa8aa
Fix font baseline selection for text-box-edge: text. r=layout-reviewers,emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a3209c786f13
https://hg.mozilla.org/integration/autoland/rev/22bb39905ab2
Revert "Bug 2055372 - Fix font baseline selection for text-box-edge: text. r=layout-reviewers,emilio" for causing wpt failures at text-box-trim-multicol-013.html

Comment 4

[Silaghi Andreea]

Backed out for causing wpt failures at text-box-trim/text-box-trim-multicol-013.html
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | /css/css-inline/text-box-trim/text-box-trim-multicol-013.html | .multicol 1 - assert_equals:

Comment 5

[Sajid Anwar [:sajidanwar]]

Test failed because it was checking the layout values before the Ahem font loaded. On Linux it seems the initial font family has internal leading, so fixing the trim baseline revealed this font loading issue. Updating the patch to fix the test case.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/09eaec975420
https://hg.mozilla.org/integration/autoland/rev/1bf94d904689
Fix font baseline selection for text-box-edge: text. r=layout-reviewers,emilio

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/61354 for changes under testing/web-platform/tests

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1bf94d904689

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot