Closed Bug 205538 Opened 21 years ago Closed 21 years ago

Use hyphens instead of underscores in caps prefs for CID's

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: adamlock, Assigned: dbradley)

References

Details

Attachments

(2 files)

activex.js patch
1.80 KB, patch
dbradley
: review+
alecf
: superreview+
asa
: approval1.4+
Details | Diff | Splinter Review
Removes the hyphen to underscore replacement
679 bytes, patch
adamlock
: review+
alecf
: superreview+
asa
: approval1.4+
Details | Diff | Splinter Review
Class IDs should be specified in prefs using hyphens instead of underscores for convenience.
Documentation in activex.js will also need updating
Attached patch activex.js patch — — Splinter Review
Patch to the documentation in this file.
Comment on attachment 123168 [details] [diff] [review] Removes the hyphen to underscore replacement Looking for reviews, simple one liner.
Attachment #123168 - Flags: superreview?(alecf)
Attachment #123168 - Flags: review?(adamlock)
I'll post an updated patch if we can leave off the prefix as well.
Status: NEW → ASSIGNED
Comment on attachment 123168 [details] [diff] [review] Removes the hyphen to underscore replacement r=adamlock
Attachment #123168 - Flags: review?(adamlock) → review+
Comment on attachment 123168 [details] [diff] [review] Removes the hyphen to underscore replacement sr=alecf and to answer your e-mail question I'd prefer you left the "CID" in there
Attachment #123168 - Flags: superreview?(alecf) → superreview+
Comment on attachment 123165 [details] [diff] [review] activex.js patch r=dbradley
Attachment #123165 - Flags: superreview?(alecf)
Attachment #123165 - Flags: review+
Comment on attachment 123165 [details] [diff] [review] activex.js patch sr=alecf (but you really should make a doc about this on mozilla.org rather than putting documentation into a file that must be read and parsed at runtime!)
Attachment #123165 - Flags: superreview?(alecf) → superreview+
Comment on attachment 123165 [details] [diff] [review] activex.js patch Wanting to get this in to 1.4 if possible so as not to have to deal with two forms of class ID's in JS prefs. This patch is just comment changes and poses no risk
Attachment #123165 - Flags: approval1.4?
Comment on attachment 123168 [details] [diff] [review] Removes the hyphen to underscore replacement Wanting to get this in to 1.4 if possible so as not to have to deal with two forms of class ID's in JS prefs. This is a one line patch that removes the replace logic for hyphen's to underscore
Attachment #123168 - Flags: approval1.4?
Comment on attachment 123165 [details] [diff] [review] activex.js patch a=asa (on behalf of drivers) for checkin to 1.4
Attachment #123165 - Flags: approval1.4? → approval1.4+
Comment on attachment 123168 [details] [diff] [review] Removes the hyphen to underscore replacement a=asa (on behalf of drivers) for checkin to 1.4
Attachment #123168 - Flags: approval1.4? → approval1.4+
Patches checked in
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Summary: Use hyphens instead of underscores in caps prefs → Use hyphens instead of underscores in caps prefs for CID's
Checkins verified -
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: