2055462 - Find bar text box no longer changes color when a lightweight theme is enabled

Status: ASSIGNED

(Toolkit :: Themes, defect, P1)

Description

[moriyama164]

Attachment: Comparison of find bar text box colors in the "not found" state: broken (top) vs working (bottom)

Steps to reproduce

1. Enable a theme other than System, Light, or Dark. — e.g. open Add-ons Manager > Themes and enable Firefox Alpenglow
2. Open the find bar. — e.g. press Ctrl+F
3. Type any text in the text box that is not present on the current page. — e.g. type \

Actual result

• The text box background color does not change.

Expected result

• The text box background color turns red.

Reproduced on

• 153.0b13
• 154.0a1 (2026-07-16)

Not reproduced on

• 152.0.6

Tested on

• Gentoo Linux (KDE Plasma 6, X11)
• Windows 10 (VirtualBox VM)

Regression range

• https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1193cb5f1d74be16bfa11ba463694eb268e7a317&tochange=ec3c3eee2e4335a9ede0efb05565a83eb2f7b4c1
• Regressed by Bug 2030722

Comment 1

[moriyama164]

There is another symptom with the same root cause, explained in comment 2.

Steps to reproduce another sympton

1. Set accessibility.typeaheadfind.flashBar to 1 (the default) or a higher integer, if it is currently 0.
2. Enable a theme other than System, Light, or Dark. — e.g. open Add-ons Manager > Themes and enable Firefox Alpenglow
3. Open the find bar. — e.g. press Ctrl+F

Actual result

• The text box background color does not change.

Expected result

• The text box briefly flashes between a yellow background and the normal background a few times.

Additional notes

Each time the find bar is opened while accessibility.typeaheadfind.flashBar is 1 or higher, the text box flashes and the value is decremented by 1. Once it reaches 0, the text box no longer flashes. To check the flashing behavior multiple times, set it to a larger value in step 1.

Comment 2

[moriyama164]

These appear to be caused by the following change in Bug 2030722 (toolkit/themes/shared/findbar.css#62-113):

 .findbar-textbox {
   appearance: none;
-  background-color: var(--input-bgcolor, var(--toolbar-field-background-color));
-  color: var(--input-color, var(--toolbar-field-text-color));
+  background-color: var(--input-text-background-color);
+  color: var(--input-text-color);
+
+  :root[lwtheme] & {
+    background-color: var(--toolbar-field-background-color);
+    color: var(--toolbar-field-text-color);
+  }
+
   ...(omitted 31 lines, unchanged)...
 
   &[status="notfound"] {
     background-color: rgba(226, 40, 80, 0.3);
     color: inherit;
   }
 
   &[flash="true"] {
     background-color: rgba(255, 233, 0, 0.3);
     color: inherit;
   }
 }

The new selector :root[lwtheme] & has specificity 0-3-0 (one pseudo-class :root, one attribute selector [lwtheme] and one class selector for .findbar-textbox), which is higher than the 0-2-0 specificity of &[status="notfound"] and &[flash="true"] (one class selector plus one attribute selector each). As a result, regardless of source order, :root[lwtheme] & always overrides the "not found" and "flash" state colors whenever a lightweight theme is active.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2030722

Comment 4

[Dan Mehic]

Hello folks, I'm the REO for this week. Can we get a an assignee of this bug and appropriate S/P since it's affecting 153/154? Thank you.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2030722

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox153 (release). However, the bug still isn't assigned.

:cbellini, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 7

[Jon Oliver]

Attachment: WIP: Bug 2055462 - Update findbar styles for lightweight theme colors

• Updates findbar textbox styles to use toolbar-field tokens more consistently
• Adds nativeTheme values for toolbar-field tokens
• Adds test to ensure that findbar textbox uses correct lwtheme values