Make mSpare a list of chunks
Categories
(Core :: Memory Allocator, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox157 | --- | fixed |
People
(Reporter: pbone, Assigned: pbone)
References
(Blocks 3 open bugs, Regressed 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(8 external files)
Making mSpare a list of chunks has three benefits.
- I was experimenting with reducing the run header size which would make detecting empty runs trickier and the invariant that there's only ever one spare chunk would go away.
- Part of Bug 2043962, on Windows the mSpare list becomes the entire chunk cache.
- It allows us to release chunks during Purge time which is faster than sychronousoy with free().
| Assignee | ||
Comment 2•4 months ago
|
||
I have a series of patches. There's things missing:
- Purge() is quite complex and I don't feel great about that. But we DO want the semantics of releasing entire chunks there.
- The global cache should be disabled on Windows but not other OSs.
- We need to double-check that low memory does ask mozjemalloc to purge, which will then release chunks.
- "one weird trick" needs to be able to get chunks from other arenas (or just force them to flush).
| Assignee | ||
Comment 3•4 months ago
|
||
| Assignee | ||
Comment 4•4 months ago
|
||
| Assignee | ||
Comment 5•4 months ago
|
||
| Assignee | ||
Comment 6•4 months ago
|
||
| Assignee | ||
Comment 7•4 months ago
|
||
Updated•4 months ago
|
Updated•3 months ago
|
Updated•3 months ago
|
Updated•3 months ago
|
Updated•3 months ago
|
Updated•3 months ago
|
| Assignee | ||
Comment 8•3 months ago
|
||
| Assignee | ||
Comment 9•3 months ago
|
||
Comment 10•3 months ago
|
||
Comment 11•3 months ago
|
||
Comment 12•3 months ago
|
||
Backed out for causing sm bustages @expr-decompiler-bug1475953.js.
| Assignee | ||
Comment 13•2 months ago
|
||
This change means that:
- a purging chunk is never the spare chunk,
- a spare chunk is never purging.
- RemoveChunk is never called on a spare chunk or a chunk in the
mDirtyChunks list. - RemoveChunk is never called on a purging chunk and therefore can
never fail. - Because RemoveChunk cannot fail the mDying flag and hand-off between
purging and removing chunks can be removed. - After purging an empty chunk should always be demoted to spare
(either because it became empty or it was empty and spare earlier). - Detection of empty chunks after purging has moved to
FinishPurgingInChunk().
This patch deletes more lines than it inserts, and many of them are
comments or assertions. it makes other patches in this stack simpler
too!
Updated•2 months ago
|
Updated•2 months ago
|
Updated•2 months ago
|
Updated•2 months ago
|
Updated•2 months ago
|
Updated•2 months ago
|
Updated•2 months ago
|
Updated•2 months ago
|
Comment 14•2 months ago
|
||
Comment 15•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fa23a5a6b467
https://hg.mozilla.org/mozilla-central/rev/ececbb3bdaeb
https://hg.mozilla.org/mozilla-central/rev/d3af02b65de8
https://hg.mozilla.org/mozilla-central/rev/e65c06ceb614
https://hg.mozilla.org/mozilla-central/rev/7f4554a1f2ef
https://hg.mozilla.org/mozilla-central/rev/4cf78e67f9d9
https://hg.mozilla.org/mozilla-central/rev/8f391f452d75
https://hg.mozilla.org/mozilla-central/rev/d04c97347dcc
| Assignee | ||
Updated•2 months ago
|
Comment 16•2 months ago
|
||
Perfherder has detected a browsertime performance change from push d04c97347dcc984bc6a4d49fa0933411f715727b.
No action is required from the author; this comment is provided for informational purposes only.
| Improvements | Test | Platform | Options | Absolute values [old vs new] | Performance Profiles |
|---|---|---|---|---|---|
| 21% | ve-av1-q-i420 wallclock-for-tracking-only (doc) | linux2404-64-nightlyasrelease | fission webrender | 8,696.12 ms -> 6,858.90 ms | Before/After |
| 7% | addkARN time_duration (doc) | linux2404-64-shippable | fission webrender | 44,400.93 ms -> 41,485.86 ms | Before/After |
| 6% | ve-av1-q-cam av01.0.04M.08 camera quality encode - first encode to last output (doc) | macosx1470-64 | fission webrender | 4,613.71 ms -> 4,330.12 ms | Before/After |
| 6% | ve-av1-q-cam (doc) | macosx1470-64 | fission webrender | 4,613.71 score -> 4,330.12 score | Before/After |
| 5% | ve-av1-q-i420 av01.0.04M.08 I420 canvas quality encode - first encode to last output (doc) | windows11-64-24h2-shippable | fission webrender | 4,540.61 ms -> 4,319.40 ms | Before/After |
| ... | ... | ... | ... | ... | ... |
| 3% | speedometer3 TodoMVC-JavaScript-ES6-Webpack-Complex-DOM/total (doc) | linux2404-64-nightlyasrelease | fission webrender | 63.69 ms -> 61.64 ms | Before/After |
Need Help or Information?
If you have any questions, please reach out to fbilt@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
Comment 17•2 months ago
|
||
Perfherder has detected a talos performance change from push d04c97347dcc984bc6a4d49fa0933411f715727b.
No action is required from the author; this comment is provided for informational purposes only.
| Improvements | Test | Platform | Options | Absolute values [old vs new] |
|---|---|---|---|---|
| 36% | perf_reftest_singletons inline-style-cache-1.html (doc) | linux2404-64-shippable | e10s fission stylo webrender | 297.02 ms -> 190.49 ms |
| 33% | perf_reftest_singletons inline-style-cache-1.html (doc) | macosx1470-64-shippable | e10s fission stylo webrender | 329.02 ms -> 221.69 ms |
| 22% | perf_reftest_singletons inline-style-cache-1.html (doc) | windows11-64-24h2-shippable | e10s fission stylo webrender | 178.50 ms -> 140.11 ms |
| 16% | pdfpaint issue6165.pdf (doc) | macosx1470-64-shippable | e10s fission stylo webrender-sw | 767.04 ms -> 641.87 ms |
| 12% | pdfpaint issue6165.pdf (doc) | linux2404-64-shippable | e10s fission stylo webrender-sw | 735.99 ms -> 647.02 ms |
| ... | ... | ... | ... | ... |
| 5% | perf_reftest_singletons overflow-changed-tracker-1.html?n=20000 (doc) | macosx1470-64-shippable | e10s fission stylo webrender | 235.03 ms -> 222.98 ms |
Need Help or Information?
If you have any questions, please reach out to afinder@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
Updated•2 months ago
|
Description
•