2055569 - Clean up perfcompare api endpoint for Mann-Whitney-U

Status: ASSIGNED

(Testing :: PerfCompare, task)

Description

[Kala Severe [:kala]]

PerfCompare backend (https://github.com/mozilla/treeherder) has fields that aren't used in the frontend, so it needs some cleanup. Mostly includes fields from the MannWhitneyResultsItem like kde_new, kde_base. We also don't need silverman_kde.

Comment 1

[Daniel Gopar [:gopar]]

Here are some of my findings (limited to MannWhitneyResultsItem):

Fields not used:
- kde_new
- kde_base
- is_fit_good
- is_significant
- performance_interpretation
- warning_c_delta
- silverman_kde (references to be removed in an upcoming PR)

Fields that are referenced only once in src/components/CompareResults/MannWhitneyCompareMetrics.tsx
and src/__tests__/CompareResults/RevisionRowExpandable.test.tsx:

• ks_test
• shapiro_wilk_test_new
• shapiro_wilk_test_base

can they be removed? Would be rather a small tweak to do so.

Comment 2

[Daniel Gopar [:gopar]]

Adding comment for request for info

Comment 3

[Kala Severe [:kala]]

I'll get back to you after I've cleaned up those components.

Comment 4

[Kala Severe [:kala]]

Hi Gopar,

For now leave the following fields:

ks_test
shapiro_wilk_test_new
shapiro_wilk_test_base

I have a PR up that removes all these unused enpoints, including the silverman_kde flag
https://github.com/mozilla/perfcompare/pull/1079

Comment 5

[Daniel Gopar [:gopar]]

Backend PR has been pushed for review as well:
https://github.com/mozilla/treeherder/pull/9794