Closed Bug 2055739 Opened 6 days ago Closed 1 day ago

[wpt-sync] Sync PR 61351 - Fix sequential focus starting point for slot elements

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
155 Branch
Tracking Status
firefox155 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 61351 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/61351
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Fix sequential focus starting point for slot elements

This patch fixes the resulting sequential focus starting point in the case that the currently focused element is being slotted and then gets removed. Without this patch, sequential focus gets reset to the start of the document, and with this patch it goes to the next element it would have gone to if the element never got removed.

This fix makes us match the behavior in firefox and safari.

Also fixed a crash in FixupRemovedNodeAcrossShadowBoundary by checking if the node being removed is immediately before the range boundary.

Fixed: 512749482
Change-Id: I9a997ea269ebcac69270a5bc9bf63957148e79a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7853014
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1658892}


Manual export of https://crrev.com/c/7853014, which could not be applied cleanly on ec4f7f1772cb82f16080807b1bc230083027f46f.

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 195 tests

Status Summary

Firefox

OK : 1[GitHub] 190[Gecko-linux2404-64-debug] 191[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 2[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 19[GitHub] 434[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 435[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 436[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 308[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 309[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]

Chrome

OK : 1
PASS : 15
FAIL : 4

Safari

PASS : 10
FAIL : 9
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/992256c10d46 https://hg.mozilla.org/integration/autoland/rev/f50fc566c5c8 [wpt PR 61351] - Fix sequential focus starting point for slot elements, a=testonly
Status: NEW → RESOLVED
Closed: 1 day ago
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
You need to log in before you can comment on or make changes to this bug.