2055887 - The pref.general.disable_button.default_browser is no longer working to disable the default Firefox button

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Mike Kaply [:mkaply]]

We have a number of legacy preferences that are used to disable things in settings.

When these preferences are locked, the item is disabled.

I'm not sure how many of these are still important, but I did just get a report of someone using pref.general.disable_button.default_browser so I at least want to make that one work.

We should keep an eye out to see if we get reports of the other ones not working.

Again, the value doesn't matter; the act of locking it is what causes it to disable the item in preferences.

Examples are:

pref.general.disable_button.default_browser
pref.browser.homepage.disable_button.current_page
pref.browser.homepage.disable_button.bookmark_page
pref.browser.homepage.disable_button.restore_default
pref.privacy.disable_button.view_passwords
security.disable_button.openCertManager
security.disable_button.openDeviceManager
app.update.disable_button.showUpdateHistory
pref.downloads.disable_button.edit_actions
pref.privacy.disable_button.cookie_exceptions
pref.privacy.disable_button.tracking_protection_exceptions
pref.privacy.disable_button.view_passwords_exceptions
pref.advanced.proxies.disable_button.reload
pref.browser.language.disable_button.up
pref.browser.language.disable_button.down

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 2055887 - Make pref.general.disable_button.default_browser work again. r?mstriemer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a38058c5fe71
https://hg.mozilla.org/integration/autoland/rev/529723e49f5b
Make pref.general.disable_button.default_browser work again. r=mstriemer

Comment 3

[YUKI "Piro" Hiroshi]

On ESR140, we use:

• pref.downloads.disable_button.edit_actions (Downloads > Files and applications > Action) (bug 2056448: does this need to be reopened?)
• pref.privacy.disable_button.view_passwords (Password and autofill > Manage saved passwords) (but it is not critical: disabling password manager looks reasonable alternative.)
• pref.privacy.disable_button.cookie_exceptions (Privacy and security > Browsing data > Manage exceptions)
• pref.privacy.disable_button.tracking_protection_exceptions (Privacy and security > Enhanced Tracking Protection > Advanced settings > Manage exceptions)

Should I file them as separate bug for each?

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/529723e49f5b

Comment 5

[Mike Kaply [:mkaply]]

Should I file them as separate bug for each?

Nope, I'll file one bug and cover them. Thanks for the info.

Comment 6

[Phabricator Automation]

firefox-esr153 Uplift Approval Request

• User impact if declined/Reason for urgency: Previously working prefs stop working in the ESR
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Only affects this one pref path
• String changes made/needed?: None
• Is Android affected?: no

Comment 7

[Mike Kaply [:mkaply]]

Attachment: Bug 2055887 - Make pref.general.disable_button.default_browser work again.

Original Revision: https://phabricator.services.mozilla.com/D312763

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr153/rev/8a62c8c52e6b