2055901 - [wpt-sync] Sync PR 61368 - Canvas2D: Respect EXIF orientation for cross-origin CSSImageValue

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 61368 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/61368
Details from upstream follow.

Kevin Babbitt <[e-mail]> wrote:

Canvas2D: Respect EXIF orientation for cross-origin CSSImageValue

Enforce kRespectImageOrientation for any source that would taint the
origin, including CSS image values.

The IsImageBitmap() || IsImageElement() checks which previously gated
the WouldTaintOrigin() check had been introduced to fix a CHECK failure
in SVGImage::CheckLoaded(); see https://crrev.com/c/2521049. However, in
https://crrev.com/c/5892795 we removed the call to CheckLoaded() on this
path, so the image type gates are no longer needed.

Fixed: 517655953
Change-Id: I1e1838c3af56264fb49c4086c9cf6ae28fe84d15
Reviewed-on: https://chromium-review.googlesource.com/8102890
WPT-Export-Revision: b3a4ab51c6633a58008cf19f09a582bfb9924f49

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3200ef45fbca4f451f0583f653b343beacfe03c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 34 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS : 2[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 29[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 4
TIMEOUT: 1

Chrome

FAIL : 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-images/image-orientation/image-orientation-exif-png.html [wpt.fyi]: FAIL
• /css/css-images/image-orientation/image-orientation-img-object-fit.html [wpt.fyi]: FAIL
• /css/css-images/image-orientation/image-orientation-none-cross-origin-canvas-css-image-value.sub.html [wpt.fyi]: TIMEOUT (Chrome: FAIL, Safari: PASS)
• /css/css-images/image-orientation/image-orientation-none-cross-origin-canvas.html [wpt.fyi]: FAIL
• /css/css-images/image-orientation/image-orientation-none-cross-origin-svg.html [wpt.fyi]: FAIL

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/108b4904380e
https://hg.mozilla.org/integration/autoland/rev/6058acddfe3c
[wpt PR 61368] - Canvas2D: Respect EXIF orientation for cross-origin CSSImageValue, a=testonly
https://github.com/mozilla-firefox/firefox/commit/61ffa7085b0e
https://hg.mozilla.org/integration/autoland/rev/da33d8eb548c
[wpt PR 61368] - Update wpt metadata, a=testonly

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/6058acddfe3c
https://hg.mozilla.org/mozilla-central/rev/da33d8eb548c