2055902 - Nova address bar's rounded ends are thicker and blurrier than before (on Windows?)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: 154_bad_screenshot.png

Nical and Drew: this Nova bug is a regression from border bug 2051358. I bisected to this autoland push:

https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=63b2ec62d67e5073fa0b901c1c3c7efb8aa9bc07&tochange=9d3cec6ffc71f3e1659210135bc7415bdacc7d6d

Steps to reproduce

1. Enable browser.nova.enabled pref.
2. Open a new tab and focus the address bar.
3. Maximize the browser window! (I'm testing on Windows 11.) The bug is not reproducible in a non-maximized window.
4. Make sure you DO NOT have the legacy search bar! Adding the legacy search bar makes this bug go away.
5. Look at the address bar's rounded ends.

Actual result

The address bar's rounded ends are thicker and blurrier than the address bar's thin horizontal lines. See the attached screenshots.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: 153_good_screenshot.png

Expected result

The address bar's rounded ends should be as thin and crisp as the address bar's thin horizontal lines.

Comment 2

[Drew Willcoxon :adw]

Nice catch, thanks Chris. We're not doing anything unusual here in the front-end, and given the regressing bug, I feel pretty safe in saying this is a graphics bug.

We did make a change to this border recently in bug 2053381, but it's just a normal border.

Comment 3

[Drew Willcoxon :adw]

Attachment: screenshot from latest m-c

Here's a Windows 11 low-DPI zoomed-in screenshot that shows the same thing as Chris's screenshot, just a little more clearly in case it helps.

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: 154_macOS_screenshot.png

FWIW, Nova's rounded border looks the same in 153 and 154 on macOS.

Why the difference between Windows and macOS? I haven't tested Linux.

Comment 5

[Sören Hentzschel]

FWW, I see a very similar issue on one of my websites on macOS and also found bug 2051358 as the cause. I filed bug 2056021.

Comment 6

[Nicolas Silva [:nical]]

Attachment: Bug 2055902 - Prevent long solid borders from scaling down the corner tasks. r=#gfx-reviewers

The solid corners don't use render tasks so they don't need to be considered when picking the largest task side.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/02e9b8be663a
https://hg.mozilla.org/integration/autoland/rev/e01c15577d62
Prevent long solid borders from scaling down the corner tasks. r=gfx-reviewers,gw

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e01c15577d62

Comment 10

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:nical, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox154 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2051358

Comment 12

[Chris Peterson [:cpeterson]]

statis-firefox154 = wontfix

Nova is preffed off in 154, so there is no need to uplift this fix from Nightly 155 to Beta 154.

Comment 13

[Sören Hentzschel]

Nova is preffed off in 154, so there is no need to uplift this fix from Nightly 155 to Beta 154.

It's a platform bug and not related to Nova. Maybe Nova triggered it for the Firefox interface, but websites can be affected as well, see bug 2056021.

Comment 14

[Sören Hentzschel]

Restoring the needinfo? request for the reason mentioned in comment 13.

Comment 15

[Nicolas Silva [:nical]]

Attachment: Bug 2055902 - Prevent long solid borders from scaling down the corner tasks.

The solid corners don't use render tasks so they don't need to be considered when picking the largest task side.

Original Revision: https://phabricator.services.mozilla.com/D313045

Comment 16

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Visual correctness issue
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Simple patch
• String changes made/needed?: None.
• Is Android affected?: yes

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9233345fd425
https://hg.mozilla.org/releases/mozilla-beta/rev/ca12ddcfde6c