2055955 - Text input should still be possible through EditContext when another element is selected but not focused

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Leo Tenenbaum [:ltenenbaum]]

Attachment: canvas.html

I am thinking that for canvas-based EditContext to be accessible, it will be necessary to keep the selection in the EditContext in sync with the selection in the DOM fallback content, as demonstrated in the attached file. However, we don't allow text input if the selection is outside of the EditContext associated element.

(It's possible that this causes issues even with DOM-based EditContext, so I'll mark this as blocking bug 2046107.)

Comment 1

[Leo Tenenbaum [:ltenenbaum]]

Although, perhaps we shouldn't accept text input for DOM-based EditContext when the selection is somewhere else, since the DOM selection is supposed to correspond to the selection in the EditContext.
Edit: Chrome does accept input for DOM-based EditContext even if the selection is somewhere else, so let's follow that.

Comment 2

[Leo Tenenbaum [:ltenenbaum]]

Oh hmm no, Chrome actually just forces the selection to stay in the DOM EditContext, even if it's changed by the Selection API. So it's fine to handle this for canvas only.

Comment 3

[Leo Tenenbaum [:ltenenbaum]]

No, that's wrong, Chrome does allow the selection to go outside, but it doesn't render the caret, even if caret browsing is enabled.

Comment 4

[Leo Tenenbaum [:ltenenbaum]]

Attachment: Bug 2055955 - Allow text input into focused EditContext even if selection is elsewhere. r=masayuki

Comment 5

[Leo Tenenbaum [:ltenenbaum]]

https://ltenmoz.github.io/editcontext-canvas/index.html is a more fleshed-out editor than the one attached here.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ca1b52a68258
https://hg.mozilla.org/integration/autoland/rev/051c443862b3
Allow text input into focused EditContext even if selection is elsewhere. r=masayuki

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/61576 for changes under testing/web-platform/tests

Comment 8

[rperta]

https://hg.mozilla.org/mozilla-central/rev/051c443862b3

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot