[wpt-sync] Sync PR 61377 - [css-mixins] Allow @mixin definitions without a parameter list
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox155 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 61377 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/61377
Details from upstream follow.
Stephanie Zhang <stephanie.zhang@microsoft.com> wrote:
[css-mixins] Allow @mixin definitions without a parameter list
Accept a bare \<dashed-ident> prelude, so
@mixin --foo {}is valid and
equivalent to@mixin --foo() {}. Previously, a \<function-token> was
required, even though @apply already allowed omitting the parentheses.Spec change: https://github.com/w3c/csswg-drafts/pull/14151
Issue: https://github.com/w3c/csswg-drafts/issues/13015Change-Id: Ib2ccf89e5f374facd6d45d0d9bd994d9d0ef9c3c
Fixed: 496172417
Reviewed-on: https://chromium-review.googlesource.com/8111117
WPT-Export-Revision: ed4b634bbdc073c1c5e6921fec73495feb6febe1
|
Assignee | |
Updated•5 days ago
|
|
|
Assignee | |
Comment 1•5 days ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=38066a7601249ba6586c77b2e8f232eba782d11d
|
|
Assignee | |
Comment 2•5 days ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 22 tests and 4 subtests
Status Summary
Firefox
OK : 2[GitHub] 22[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS: 1[GitHub] 13[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 7[GitHub] 78[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
Chrome
OK : 2
PASS: 6
FAIL: 2
Safari
OK : 2
PASS: 1
FAIL: 7
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-mixins/mixins/apply-nested-declarations.html [wpt.fyi]
- Can mix declarations into pseudo-elements:
FAIL
- Can mix declarations into pseudo-elements:
- /css/css-mixins/mixins/apply-within-mixin.html [wpt.fyi]
- CSS Mixins: Mixins depending on other mixins:
FAIL
- CSS Mixins: Mixins depending on other mixins:
- /css/css-mixins/mixins/contents-nested-declarations-fallback.html [wpt.fyi]
- Can mix declarations into pseudo-elements via @contents:
FAIL
- Can mix declarations into pseudo-elements via @contents:
- /css/css-mixins/mixins/contents-nested-declarations.html [wpt.fyi]
- Can mix declarations into pseudo-elements via @contents:
FAIL
- Can mix declarations into pseudo-elements via @contents:
- /css/css-mixins/mixins/contents-rule.html [wpt.fyi]
- Simple @contents with no fallback:
FAIL - Implicit semicolon after @contents, at end of block:
FAIL - Block in @apply overrides fallback:
FAIL - Fallback is used if @apply has no block:
FAIL - Empty @contents block is allowed, but does nothing:
FAIL - Empty @contents parameter does not crash:
FAIL
- Simple @contents with no fallback:
- /css/css-mixins/mixins/mixin-basic.html [wpt.fyi]
- CSS Mixins: Basic test:
FAIL(Chrome:FAIL, Safari:FAIL)
- CSS Mixins: Basic test:
- /css/css-mixins/mixins/mixin-conditionals.html [wpt.fyi]
- @media and @supports wrapping @result:
FAIL - @container wrapping @result:
FAIL - @media and @supports wrapping locals:
FAIL - @container wrapping locals:
FAIL - @container wrapping locals with different container is not cached:
FAIL - Bare locals overriding earlier conditional-wrapped locals:
FAIL - Nested @media and @container locals:
FAIL
- @media and @supports wrapping @result:
- /css/css-mixins/mixins/mixin-cross-stylesheet.html [wpt.fyi]
- CSS Mixins: Mixin from another stylesheet:
FAIL
- CSS Mixins: Mixin from another stylesheet:
- /css/css-mixins/mixins/mixin-cssom.tentative.html [wpt.fyi]
- serialization of @mixin:
FAIL(Chrome:PASS, Safari:FAIL) - serialization of rule with @apply:
FAIL(Chrome:PASS, Safari:FAIL) - serialization of @mixin with @contents:
FAIL(Chrome:PASS, Safari:FAIL) - serialization of rule with @apply and contents argument:
FAIL(Chrome:PASS, Safari:FAIL) - serialization of @mixin with parameters:
FAIL(Chrome:PASS, Safari:FAIL) - serialization of @mixin defined without a parameter list:
FAIL(Chrome:FAIL, Safari:FAIL)
- serialization of @mixin:
- /css/css-mixins/mixins/mixin-cycle.tentative.html [wpt.fyi]
- CSS Mixins: Cycles:
FAIL
- CSS Mixins: Cycles:
- /css/css-mixins/mixins/mixin-declarations.html [wpt.fyi]
- CSS Mixins: Declarations directly in mixin:
FAIL
- CSS Mixins: Declarations directly in mixin:
- /css/css-mixins/mixins/mixin-from-import-with-media-queries.html [wpt.fyi]
- CSS Mixins: @import with media queries:
FAIL
- CSS Mixins: @import with media queries:
- /css/css-mixins/mixins/mixin-from-import.html [wpt.fyi]
- CSS Mixins: Mixin from an imported stylesheet:
FAIL
- CSS Mixins: Mixin from an imported stylesheet:
- /css/css-mixins/mixins/mixin-invalidation.tentative.html [wpt.fyi]
- invalidation of @mixin from same stylesheet:
FAIL - invalidation of @mixin from different stylesheet:
FAIL - invalidation on adding @apply rule:
FAIL
- invalidation of @mixin from same stylesheet:
- /css/css-mixins/mixins/mixin-layers.html [wpt.fyi]
- Mixins work inside layers:
FAIL - Mixins work inside layers (anonymous):
FAIL - Mixins in stronger layer wins:
FAIL - Mixins in stronger layer wins (source order matching layer order):
FAIL
- Mixins work inside layers:
- /css/css-mixins/mixins/mixin-locals.html [wpt.fyi]
- Basic local support:
FAIL - Mixin is not cached if locals are different:
FAIL - Locals resolve against each other:
FAIL - Locals resolve against parameters:
FAIL - Parameters do not resolve against locals:
FAIL - Locals after @result are seen:
FAIL
- Basic local support:
- /css/css-mixins/mixins/mixin-media-query-invalidation-2.html [wpt.fyi]
- CSS Mixins: Invalidates on negative media query becoming positive:
FAIL
- CSS Mixins: Invalidates on negative media query becoming positive:
- /css/css-mixins/mixins/mixin-media-query-invalidation.html [wpt.fyi]
- CSS Mixins: Media Queries and invalidation:
FAIL
- CSS Mixins: Media Queries and invalidation:
- /css/css-mixins/mixins/mixin-parameters.html [wpt.fyi]
- Mixins with invalid parameter lists are ignored:
FAIL - Basic mixin parameter passing:
FAIL - Mixins can be called multiple times with different parameters:
FAIL - Too few parameters and no default ignores mixin:
FAIL - Mixin argument parsing with arguments wrapped in {}:
FAIL - Defaults in mixin parameters:
FAIL - Fallback is ignored if argument is given:
FAIL - Fallback is used with no parameter and no default:
FAIL - var() can be accessed from attributes:
FAIL - var() resolves typed parameters:
FAIL - var() refuses illegal syntax parameters, but does not fail entire mixin:
FAIL - var() can access parameters from outer mixins:
FAIL - var() works inside if, in condition and true branch:
FAIL - var() works inside if, in condition and false branch:
FAIL - Mixin arguments are resolved at call site, not at use:
FAIL - var() supports default parameters:
FAIL - var() typed default parameters are resolved against the element:
FAIL
- Mixins with invalid parameter lists are ignored:
- /css/css-mixins/mixins/mixin-parsing.html [wpt.fyi]
- @layer (statement) is invalid in @mixin:
FAIL - @layer (block) is invalid in @mixin:
FAIL - @layer (anonymous) is invalid in @mixin:
FAIL - @layer (statement) within @result is valid in @mixin:
FAIL - @layer (block) within @result is valid in @mixin:
FAIL - @layer (anonymous) within @result is valid in @mixin:
FAIL - style rule is valid in @mixin:
FAIL - style rule (relative) is valid in @mixin:
FAIL - @media is valid in @mixin:
FAIL - @supports is valid in @mixin:
FAIL - @container is valid in @mixin:
FAIL - @starting-style is valid in @mixin:
FAIL - @scope is valid in @mixin:
FAIL - @scope (implicit) is valid in @mixin:
FAIL
- @layer (statement) is invalid in @mixin:
- /css/css-mixins/mixins/mixin-shadow-dom.html [wpt.fyi]
- Style in shadow DOM should have access to outside non-adopted mixins:
FAIL - Style in shadow DOM should have access to inside mixins:
FAIL - Style in shadow DOM should have access to mixins from adopted stylesheets:
FAIL
- Style in shadow DOM should have access to outside non-adopted mixins:
https://hg.mozilla.org/mozilla-central/rev/8c76fbe25c44
https://hg.mozilla.org/mozilla-central/rev/57e1c67fc364
Description
•