2056102 - Increase the maximum number of PDF.js preferences

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Aditi]

Steps to reproduce:

PDF.js PR #20729 adds disableWorkerRendering as a new OptionKind.PREFERENCE option.

Actual results:

PdfStreamConverter.sys.mjs currently limits preference fetching to 50,
which means that one preference could be omitted after this change.

Expected results:

As per the comment here, we should increase MAX_NUMBER_OF_PREFS from 50 to 60 (just a potential value) to keep Mozilla Central synchronised with the PDF.js app_options_spec.js number of preferences.

Comment 1

[Aditi]

I can't edit the original description, as I probably don't have permissions, the description's supposed to be:

PDF.js PR #20729 adds disableWorkerRendering as a new
OptionKind.PREFERENCE option.

PdfStreamConverter.sys.mjs currently limits preference fetching to 50.
Increase MAX_NUMBER_OF_PREFS from 50 to 60 to provide some headroom and
keep Mozilla Central synchronized with the corresponding limit in
test/unit/app_options_spec.js.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Settings UI' component, but is not confident enough to move the bug to that component.

Comment 3

[Aditi]

Attachment: Bug 2056102 - Increase the maximum number of PDF.js preferences to 60. r?#pdfjs-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/95c37ccf3d2c
https://hg.mozilla.org/integration/autoland/rev/b13c5fe826ae
Increase the maximum number of PDF.js preferences to 60. r=pdfjs-reviewers,calixte

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b13c5fe826ae