2056232 - Do not expose IP Protection feature if not fully translated

Status: ASSIGNED

(Firefox :: IP Protection, task)

Description

[Andrea Marchesini [:baku]]

In bug 2052044 we introduced mozILocaleService.isLocalizedEnough and areMessagesLocalized. This bug uses these new methods in IP Protection (desktop only): the feature is not shown if the user has never interacted with it and the current locale does not fully translate it.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 2056232 - Do not expose IP Protection feature if not fully translated

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 2056232 - Do not expose IP Protection feature if not fully translated

Comment 3

[Bryan Olsson [:bolsson]]

Hi :baku - what happens in these circumstances:

1. A user downloaded an en-US build, never interacted with VPN, and changed the UI to a locale without coverage.
2. A user downloaded an en-US build, interacted with VPN while on en-US, then changed the UI to a locale without coverage.
3. A user downloaded a locale build without coverage, and changes UI to en-US or a locale with coverage.
4. A user has a build with coverage, never interacts with the VPN, and a new source string is added but a translation is not.

I also recall from our discussion on this feature that the idea was to hide a feature without coverage, but not indefinitely - I assumed there'd always be some target version in mind. Is this not the case anymore?

Comment 4

[Andrea Marchesini [:baku]]

1. A user downloaded an en-US build, never interacted with VPN, and changed the UI to a locale without coverage.

The feature goes away.

2. A user downloaded an en-US build, interacted with VPN while on en-US, then changed the UI to a locale without coverage.

The feature will remain active.

3. A user downloaded a locale build without coverage, and changes UI to en-US or a locale with coverage.

the feature appears (at the next restart)

4. A user has a build with coverage, never interacts with the VPN, and a new source string is added but a translation is not.

With the current patch, the feature goes away.

I also recall from our discussion on this feature that the idea was to hide a feature without coverage, but not indefinitely - I assumed there'd always be some target version in mind. Is this not the case anymore?

We have a pref to ignore the translation coverage for that reason. We can flip that pref at any time.

Note that I'm running this as an experiment to identify the critical aspects and your questions have highlighted good points! I need to revisit a patch, but firstly the PM needs to decide the rules.

Comment 5

[Bryan Olsson [:bolsson]]

Thanks :baku for the responses. I'm adding my change requests here rather than the phabricator diff, as they merit some additional discussion and it's worth doing it where its more visible.

I'd say for this feature functionality, I'd want:

• Define a release number for which the feature is displayed to users, regardless of locale completion percentage. The goal here is to allow more time for localizers to translate feature strings before displaying to users ahead of the increased localization cadence starting in 155. I don't think we want to hide the feature forever for a myriad of reasons. I'd also like to avoid having to flip a pref manually, otherwise the risk of forgetting it is to great. I think original release version + 2 seems a decent starting point.
• We should lower the threshold from 100% to something like 80%, otherwise the risk of a feature appearing/disappearing over the course of a couple releases as strings get fixed/updated/added is too great.
• We should never hide features in Beta/Nightly
• We should also consider excluding other English locales (en-GB, en-CA) otherwise we risk hiding features needlessly