2056271 - search_the_web tool swap forces tool calls into content

Status: VERIFIED FIXED

(Core :: Machine Learning: General, task)

Description

[Bryan]

In the current system, search_the_web tool is swapped out for run_search immediately. This means what when the tool call returns, the tool is no longer in the tools list - however, the model still recognizes that this tool exists and occasionally tries to re-call it. This causes parsing bugs in the LiteLLM endpoint, forcing the tool call into the content.

see: https://mozilla.slack.com/archives/C0ADUFX0QRW/p1784544790026229

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Machine Learning: General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Bryan]

Attachment: Bug 2056271 - Removed run_search from tools and embedded behavior switch in search_the_web r?#ai-models-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/355688820d70
https://hg.mozilla.org/integration/autoland/rev/f2d201ed4744
Removed run_search from tools and embedded behavior switch in search_the_web r=tetchart,Gijs

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f2d201ed4744

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f2d201ed4744

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f2d201ed4744

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f2d201ed4744

Comment 8

[Bryan]

Attachment: Bug 2056271 - Removed run_search from tools and embedded behavior switch in search_the_web

Original Revision: https://phabricator.services.mozilla.com/D313088

Comment 9

[Bryan]

Attachment: Bug 2056271 - Removed run_search from tools and embedded behavior switch in search_the_web

Original Revision: https://phabricator.services.mozilla.com/D313088

Comment 10

[Bryan]

Attachment: Bug 2056271 - Removed run_search from tools and embedded behavior switch in search_the_web

Original Revision: https://phabricator.services.mozilla.com/D313088

Comment 11

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: the stack serves to add search_the_web tool call to smart window, which gives the assistant the ability to answer user questions directly, rather than handing off to a search engine
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: ask the smart window assistant a question requiring web search (e.g. "what are the best things to do in fl?"). the assistant should respond directly -- possibly with references / links.

on occasion, the assistant may redirect to search engine, but it should generally respond directly.

• Risk associated with taking this patch: medium
• Explanation of risk level: most behavior is unchanged. search_the_web falls back to existing behavior.

medium due to size of stack.

• String changes made/needed?: no
• Is Android affected?: no

Comment 12

[Bryan]

Attachment: Bug 2056271 - Removed run_search from tools and embedded behavior switch in search_the_web

Original Revision: https://phabricator.services.mozilla.com/D313088

Comment 13

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 155.0a1 (2026-07-23)

Comment 14

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: These patches add the search_the_web tool to the assistant, allowing the assistant to directly answer user queries, rather than handing off to a search engine.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Ask the agent a question requiring web search. The agent should respond directly -- generally also providing links to sources (although this requirement is not part of the patch).

In some cases, the agent will still hand off to the search engine, but it should mostly answer queries directly.

• Risk associated with taking this patch: low
• Explanation of risk level: Fallback behavior reverts to baseline search engine.
• String changes made/needed?: no
• Is Android affected?: no

Comment 15

[Bryan]

Attachment: Bug 2056271 - Removed run_search from tools and embedded behavior switch in search_the_web

Original Revision: https://phabricator.services.mozilla.com/D313088

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/bf8bee770bdf
https://hg.mozilla.org/releases/mozilla-beta/rev/09b3cd36e5a0

Comment 17

[Ed Lee :Mardak]

this is part of the 9 patch stack for potential exa v0 153 ride along uplifts https://phabricator.services.mozilla.com/D313875 (some abandoned for now until we get 154 beta verified)

Comment 18

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 154.0b3

Comment 19

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: the stack serves to add search_the_web tool call to smart window, which gives the assistant the ability to answer user questions directly, rather than handing off to a search engine
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: ask the smart window assistant a question requiring web search (e.g. "what are the best things to do in fl?"). the assistant should respond directly -- possibly with references / links.

on occasion, the assistant may redirect to search engine, but it should generally respond directly.

• Risk associated with taking this patch: medium
• Explanation of risk level: most behavior is unchanged. search_the_web falls back to existing behavior.

medium due to size of stack, qa verified with 154

• String changes made/needed?: yes, not exposed to localization with locales-preview
• Is Android affected?: no

Comment 20

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/d0067f018f0f
https://hg.mozilla.org/releases/mozilla-release/rev/b54a53fc6e60

Comment 21

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Release 153.0.3