2056278 - Update div lines in vertical tabs

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[Eric Pang [:epang] UX]

Attachment: div lines - veritcal tabs.png

The division line under pinned tabs and above tools is currently 1px and wider then defined in the specs.

It should be 16px wide and 2px high and use the divider token colour.

Comment 1

[Stephen Thompson [:sthompson]]

I thought we had a duplicate on file, but I can't find it.

Spec uses a token divider/color/tinted that I don't think is in the codebase. It's defined as an alias of toolbarbutton/icon/fill so we can probably make a local CSS property on the sidebar. https://www.figma.com/design/Co6vXnF5SiQMcJ7UoJvZX6/Nova-Styles--Experimental-?node-id=0-1&p=f&view=variables&var-id=174-6396&var-set-id=2-5&m=dev

Comment 2

[Julie De Lorenzo [:jdelorenzo]]

Attachment: Bug 2056278: Replace remaining placeholder strings for tab groups

Comment 3

[Phabricator Automation]

Comment on attachment 9614563 [details]
Bug 2056278: Replace remaining placeholder strings for tab groups

Revision D313541 was moved to bug 2056728. Setting attachment 9614563 [details] to obsolete.

Comment 5

[Stephen Thompson [:sthompson]]

Setting P2 based on Ania's prioritization of bug 2052284

Comment 6

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:sfoster, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[Jack Brown]

Attachment: Bug 2056278 - Resize the sidebar launcher division lines - r?#sidebar-reviewers-rotation

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b564e0206328
https://hg.mozilla.org/integration/autoland/rev/2614fc62fbd0
Resize the sidebar launcher division lines - r=desktop-theme-reviewers,tabbrowser-reviewers,sclements,dao

Comment 9

[rperta]

https://hg.mozilla.org/mozilla-central/rev/2614fc62fbd0

Comment 10

[Bogdan Birsan-Caliman, DTE]

Hello,

I have checked this issue on Nightly 156 and can confirm that the separator line between tabs and pinned tabs is now 16px wide and 2px high and uses the divider token colour.

Marking this ticket as Verified.

Comment 11

[Will]

The pinned tab divider is not centred when compact density is enabled. I filed a bug https://bugzilla.mozilla.org/show_bug.cgi?id=2067613