Closed Bug 2056373 Opened 3 months ago Closed 3 months ago

Update moz-promo illustrations in about:settings#browserIcon for better contrast in dark mode

Categories

(Firefox :: Shell Integration, task)

Product:
Firefox
Component:
Shell Integration
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
155 Branch
Tracking Flags:
Tracking Status
firefox154 --- fixed
firefox155 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 2 external files, 2 obsolete files)

kit-lock-bgtransparent.svg
19.64 KB, image/svg+xml
Details
kit-confetti-60-final.svg
18.04 KB, image/svg+xml
Details

The moz-promo images in about:settings#browserIcon have a slightly too bright background colour while in dark mode, so UX has an adjusted set for us to replace them with.

Attached image kit-confetti-60.svg (obsolete) —
Attached image kit-confetti-bgtransparent.svg (obsolete) —

These are the images I got directly from UX - they haven't gone through SVGO, and don't have the license header yet.

Attachment #9613642 - Attachment is obsolete: true
Attachment #9613643 - Attachment is obsolete: true
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d714e9c2ef86 https://hg.mozilla.org/integration/autoland/rev/9707bb8713ce Update browser icon moz-promo illustrations to look better in the dark theme. r=hjones,desktop-theme-reviewers

https://hg.mozilla.org/mozilla-central/rev/9707bb8713ce

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox155: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
Attachment #9616880 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Users with dark themes might find that the browser icon moz-promo images have too stark a contrast for that theme.
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: This is an image asset swap for images only used in the moz-promo's elements for the browser icon section of about:settings.
  • String changes made/needed?: None.
  • Is Android affected?: no
Attachment #9616880 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: