2056382 - Windows taskbar button icon not reflecting custom browser icon when not pinned

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect, P1)

Description

[Yazan Al Macki [:yazan]]

Prerequisites:

1. In a recent Windows build, ensure that browser.shell.customIcon.enabled is set to true
2. Ensure Firefox is not pinned to taskbar, and doesn't have a shortcut in per-user Start Menu directory

STR:

• Visit about:settings#appearance, and change the default browser icon

ER:

• Taskbar icon changes

AR:

• Taskbar icon remains the same

Comment 1

[Yazan Al Macki [:yazan]]

Attachment: Bug 2056382 - Add a shortcut to per user start menu folder so taskbar icon can be modified. r?mconley,hsohaney

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cba4ffe327de
https://hg.mozilla.org/integration/autoland/rev/5a12167c19e6
Add a shortcut to per user start menu folder so taskbar icon can be modified. r=mconley,hsohaney,fluent-reviewers,bolsson,mossop

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/5a12167c19e6

Comment 4

[Yazan Al Macki [:yazan]]

Attachment: Bug 2056382 - Add a shortcut to per user start menu folder so taskbar icon can be modified.

The taskbar falls back to using the icon of the shortcut (with a matching AUMID) located at the system-wide start menu path, when a matching shortcut doesn’t exist at the user-level start menu. We cannot modify the icon at the system-wide shortcut so it stays the same.

When pinned, a shortcut gets created at the user-level, which we can edit, and hence the problem doesn’t exist there. The fix is to add a shortcut to the per user start menu directory. The shell prioritizes that shortcut’s icon over the system-wide one when both are present, and we have the ability to modify it.

Original Revision: https://phabricator.services.mozilla.com/D313551

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Users will be not see the browser taskbar icon updating when using the new browser custom icon feature if their browser is not pinned to taskbar
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: medium
• Explanation of risk level: I flagged this as a medium as we are introducing a new shortcut, which affects where the taskbar icon is being read from. There were initially some concerns of possible affects to taskbar tabs but no issues were identified when reviewing the patch.
• String changes made/needed?: One string was added but translations were migrated.
• Is Android affected?: no

Comment 6

[Dianna Smith [:diannaS]]

adding l10n team for string review especially since it is so late in the beta cycle

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Hm. Didn't realize there was a string in this patch. Is it possible to pull from custom.properties directly for the Beta patch? Or is it not packaged in the Firefox omni.ja?

Comment 8

[Francesco Lodolo [:flod]]

If this was migrating from a Fluent file, it wouldn't be a problem to uplift

Missing .properties strings need to be packaged in the build and langpack, so we shouldn't uplift this patch as is.

Comment 9

[Francesco Lodolo [:flod]]

Actually, now that coffee kicked in… It's OK to uplift this to beta.

I'll run the migration in a few minutes, so translations for the new Fluent string should be in-tree tomorrow. The .properties string is staying around for the time being.

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/882dcf80f550
https://hg.mozilla.org/releases/mozilla-beta/rev/c2d5e5e6546f