2056385 - [wpt-sync] Sync PR 61423 - ContainerTiming: tests for pre-paint attribution tracker

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 61423 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/61423
Details from upstream follow.

Jose Dapena Paz <[e-mail]> wrote:

ContainerTiming: tests for pre-paint attribution tracker

Split out of the pre-paint attribution tracker implementation CL to keep
that change focused on production code.

Adds:

• Unit tests for the ContainerTimingPaintAttributionTracker and for
  ContainerTiming aggregation/caching under both flag states.
• pre_paint_tree_walk_test.cc coverage for the container-timing dirty-bit
  propagation and the ShouldInheritContainerTimingRoot cache.
• display_lock_context_test.cc coverage for the container-timing
  interaction with display locking.
• container_timing_test_utils.h, shared by blink_unittests and
  blink_perf_tests via unit_test_support.
• WPTs for container timing roots with containertiming-ignore reporting
  their own paints, plus a virtual test suite running the existing
  container-timing WPTs with ContainerTimingPrepaintTraversal enabled.

All Container Timing Web Platform Tests pass with both the legacy
implementation and the prepaint optimization.

Bug: 489959278
Change-Id: Iaad076cafb821c7807edb739db764b34072ed0bc

Reviewed-on: https://chromium-review.googlesource.com/7979158
WPT-Export-Revision: e580d5e3827e762b5a35d9e6aca43a39c4861dff

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9f85a39a6835d9b28458f166c1639b73e2f0a78

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 1 subtests

Status Summary

Firefox

OK : 4
FAIL: 4

Chrome

OK : 4
PASS: 4

Safari

OK : 4
FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /container-timing/tentative/containertiming-and-ignore-on-img-itself.html [wpt.fyi]
  • Image with both containertiming and containertiming-ignore reports its own paint.: FAIL (Chrome: PASS, Safari: FAIL)
• /container-timing/tentative/containertiming-and-ignore-on-text-itself.html [wpt.fyi]
  • Text element with both containertiming and containertiming-ignore reports its own paint.: FAIL (Chrome: PASS, Safari: FAIL)
• /container-timing/tentative/nested-containertiming-and-ignore-on-img.html [wpt.fyi]
  • Image with containertiming + containertiming-ignore inside outer containertiming reports under itself only.: FAIL (Chrome: PASS, Safari: FAIL)
• /container-timing/tentative/nested-containertiming-and-ignore-on-text.html [wpt.fyi]
  • Text element with containertiming + containertiming-ignore inside outer containertiming reports under itself only.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/504b066de86e
https://hg.mozilla.org/integration/autoland/rev/7dbe84b86398
[wpt PR 61423] - ContainerTiming: tests for pre-paint attribution tracker, a=testonly
https://github.com/mozilla-firefox/firefox/commit/41991f4d2e57
https://hg.mozilla.org/integration/autoland/rev/f55f4783a056
[wpt PR 61423] - Update wpt metadata, a=testonly

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/7dbe84b86398
https://hg.mozilla.org/mozilla-central/rev/f55f4783a056