Closed Bug 2056421 Opened 2 days ago Closed 1 day ago

[wpt-sync] Sync PR 61430 - [WebXR] Detect all frame owners in DOM Overlay

Categories

(Core :: WebVR, task, P4)

Product:
Core
Component:
WebVR
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
155 Branch
Tracking Flags:
Tracking Status
firefox155 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 61430 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/61430
Details from upstream follow.

Alexander Cooper <alcooper@chromium.org> wrote:

[WebXR] Detect all frame owners in DOM Overlay

ProcessOverlayHitTest downcasts the hit element to HTMLFrameElementBase
to decide whether to walk the content frame subtree for cross-origin
content. That base class only covers \<iframe> and \<frame>; content
embedded via \<object>, \<embed>, or \<fencedframe> owns a content frame
through HTMLFrameOwnerElement instead, so the cast returned null and
the cross-origin check was skipped.

Cast to HTMLFrameOwnerElement instead so every frame-owning element is
subject to the same origin check. Extend the ar_dom_overlay WPT with
an \<object> variant of the existing cross-origin iframe test.

Fixed: 524418836
TAG=agy
Change-Id: I43830c7a669820dbb56c3a1792d9f7c6813d1c1e
Reviewed-on: https://chromium-review.googlesource.com/8120459
WPT-Export-Revision: cf8d07024a8dd70489f1a131b9911960945c28e4

Component: web-platform-tests → WebVR
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 13 subtests

Status Summary

Firefox

OK : 1
FAIL: 13

Chrome

OK : 1
PASS: 11
FAIL: 2

Safari

OK : 1
FAIL: 13

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /webxr/dom-overlay/ar_dom_overlay.https.html [wpt.fyi]
    • Ensures DOM Overlay rejected without root element: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensures DOM Overlay feature works for immersive-ar, body element - webgl: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensures DOM Overlay feature works for immersive-ar, body element - webgl2: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensures DOM Overlay feature works for immersive-ar, div element - webgl: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensures DOM Overlay feature works for immersive-ar, div element - webgl2: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensures DOM Overlay input deduplication works - webgl: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensures DOM Overlay input deduplication works - webgl2: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensures DOM Overlay Fullscreen API doesn't change DOM overlay - webgl: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensures DOM Overlay Fullscreen API doesn't change DOM overlay - webgl2: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensures DOM Overlay interactions on cross origin iframe are ignored - webgl: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensures DOM Overlay interactions on cross origin iframe are ignored - webgl2: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensures DOM Overlay interactions on cross origin object are ignored - webgl: FAIL (Chrome: FAIL, Safari: FAIL)
    • Ensures DOM Overlay interactions on cross origin object are ignored - webgl2: FAIL (Chrome: FAIL, Safari: FAIL)

https://hg.mozilla.org/mozilla-central/rev/7ea4d5a1e8dc
https://hg.mozilla.org/mozilla-central/rev/fe3e64269e05

Status: NEW → RESOLVED
Closed: 1 day ago
status-firefox155: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
You need to log in before you can comment on or make changes to this bug.