2056488 - Disabled quickactions do not look disabled

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Dale Harvey (:daleharvey)]

Enter quickactions search mode (type "< "). All quickactions are shown, some of these are disabled ("mute audio") however they have the same styling as the rest of the actions

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 2056488 - Show disabled quickactions as disabled. r=daisuke

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3f18d69dc1a0
https://hg.mozilla.org/integration/autoland/rev/d7d0ddd5c0ab
Show disabled quickactions as disabled. r=daisuke,desktop-theme-reviewers,urlbar-reviewers,Jamie

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f42e5a45c06f
https://hg.mozilla.org/integration/autoland/rev/8abfd170ccc2
Revert "Bug 2056488 - Show disabled quickactions as disabled. r=daisuke,desktop-theme-reviewers,urlbar-reviewers,Jamie" for causing multiple failures

Comment 4

[pstanciu]

Backed out for causing multiple failures

• https://hg.mozilla.org/integration/autoland/rev/8abfd170ccc2c9694845ad3e51ef41714eb304ca
• Push with failures
• Failure Log

Comment 5

[Dale Harvey (:daleharvey)]

Ugh sorry I didnt upload the test fixes to phab before landing

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/749e5a787e74
https://hg.mozilla.org/integration/autoland/rev/31b54d6348f0
Show disabled quickactions as disabled. r=daisuke,desktop-theme-reviewers,urlbar-reviewers,Jamie

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/31b54d6348f0