2056501 - Compilation fails for risc-v with linux 6.6

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Gyorgy Sarvari]

Attachment: proposed patch

Steps to reproduce:

Cross-compile Firefox 153 to Risc-V arch using Linux kernel 6.6

Actual results:

Compilation fails, due to undefined symbols, which were first defined in Linux 6.8:

|  8:43.19 W In file included from /yocto/scarthgap/build/tmp/work/riscv64-poky-linux/firefox/153.0/firefox-153.0/firefox-build-dir/js/src/jit/Unified_cpp_js_src_jit15.cpp:38:
|  8:43.20 E /yocto/scarthgap/build/tmp/work/riscv64-poky-linux/firefox/153.0/firefox-153.0/js/src/jit/riscv64/Architecture-riscv64.cpp:319:26: error: use of undeclared identifier 'RISCV_HWPROBE_EXT_ZFHMIN'
|  8:43.20 E   319 |     if (probe[0].value & RISCV_HWPROBE_EXT_ZFHMIN) {
|  8:43.20 E       |                          ^
|  8:43.20 js/xpconnect/wrappers/XrayWrapper.o
|  8:43.20 js/xpconnect/wrappers/Unified_cpp_xpconnect_wrappers0.o
|  8:43.28 E /yocto/scarthgap/build/tmp/work/riscv64-poky-linux/firefox/153.0/firefox-153.0/js/src/jit/riscv64/Architecture-riscv64.cpp:322:26: error: use of undeclared identifier 'RISCV_HWPROBE_EXT_ZFA'
|  8:43.28 E   322 |     if (probe[0].value & RISCV_HWPROBE_EXT_ZFA) {
|  8:43.28 E       |                          ^
|  8:43.37 E /yocto/scarthgap/build/tmp/work/riscv64-poky-linux/firefox/153.0/firefox-153.0/js/src/jit/riscv64/Architecture-riscv64.cpp:325:26: error: use of undeclared identifier 'RISCV_HWPROBE_EXT_ZICOND'
|  8:43.37 E   325 |     if (probe[0].value & RISCV_HWPROBE_EXT_ZICOND) {
|  8:43.37 E       | 

Expected results:

Successful compilation.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::JavaScript Engine' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Dianna Smith [:diannaS]]

:anba maybe related to bug 2045021 according to the file?

Comment 3

[André Bargull [:anba]]

Attachment: Bug 2056501: Allow detecting newer riscv64 extensions on older kernels. r=#spidermonkey-reviewers!

Comment 4

[André Bargull [:anba]]

Yes, a regression from bug 2045021.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7b67f3b90566
https://hg.mozilla.org/integration/autoland/rev/9cfe27ed79b5
Allow detecting newer riscv64 extensions on older kernels. r=spidermonkey-reviewers,jandem

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9cfe27ed79b5

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9cfe27ed79b5

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9cfe27ed79b5

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9cfe27ed79b5

Comment 10

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected, along with ESR.
:anba, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta and ESR approvals.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox154 and the ESR status flag(s) to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[André Bargull [:anba]]

Attachment: Bug 2056501: Allow detecting newer riscv64 extensions on older kernels.

Original Revision: https://phabricator.services.mozilla.com/D313476

Comment 12

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Can't build Beta and ESR 153 for riscv64 on Linux kernels before version 6.8.
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Low risk because it only replaces external symbols with hardcoded constants. The change also only affects riscv64, which is a tier 3 target.
• String changes made/needed?: None
• Is Android affected?: no

Comment 13

[André Bargull [:anba]]

Attachment: Bug 2056501: Allow detecting newer riscv64 extensions on older kernels.

Original Revision: https://phabricator.services.mozilla.com/D313476

Comment 14

[Phabricator Automation]

firefox-esr153 Uplift Approval Request

• User impact if declined/Reason for urgency: Can't build Beta and ESR 153 for riscv64 on Linux kernels before version 6.8.
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Low risk because it only replaces external symbols with hardcoded constants. The change also only affects riscv64, which is a tier 3 target.
• String changes made/needed?: None
• Is Android affected?: no

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/1858cde36e85
https://hg.mozilla.org/releases/mozilla-beta/rev/f1644a358333

Comment 16

[BMO Github Automation]

Authored by https://github.com/anba
https://github.com/mozilla/enterprise-firefox/commit/7b67f3b9056632311ad8958d0b939796090987bf
[enterprise-main] Bug 2056501: Allow detecting newer riscv64 extensions on older kernels. r=spidermonkey-reviewers,jandem

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr153/rev/bcdaa3a4abfa