2056630 - [Nova] Broken borders for Nova vertical tabs with PB mode and custom themes

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Nika Layzell [:nika] (ni? for response)]

Attachment: Screen Recording.mov

STR:

• Enable Nova, "Vertical tabs", and "Expand sidebar on hover".
• Open a private browsing window (in practice, I've also seen this happen with custom themes)

ER:

• The tabs act similarly to how they do in a non-pb window, with a shaded area around the tabs, and a border around that area.

AR:

• No shaded area appears under the tabs, other than for a single frame when the area collapses.
• The border is broken, at the top of the vertical tabs section
• There is flashing when expanding/collapsing vertical tabs.
• The border only appears when the sidebar is locked open.

I've attached a video of this to the bug.

Comment 1

[Stephen Thompson [:sthompson]]

There are some CSS rules unsetting the border-radius and inline borders when [lwtheme], which is causing the border issues since private window theme is acting as a theme https://searchfox.org/firefox-main/source/browser/themes/shared/sidebar.css#351-361

Comment 2

[Ania]

Let's start with treating this bug as "bring the expand on hover behavior in PB mode into compliance with how it already works in the regular, classic window". Right now, the biggest discrepancy is the lack of Nova borders around the sidebar launcher and expanded sidebar as tabs are expanded.

Comment 3

[Sarah Clements [:sclements] | PTO until Sept 8th]

Let's break the various things listed here into separate bugs as needed so its easier to track and review.

Comment 4

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:sfoster, could you have a look please?

For more information, please visit BugBot documentation.

Comment 5

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 2056630 - Fix broken sidebar borders and color mismatch for lightweight themes when using expand on hover in Nova. r?#sidebar-reviewers

Pre-existing rules ensured that, when using expand on hover in a lightweight theme, the sidebar background is a solid color (--toolbox-background-color), thus making it so content area won't bleed in and obscure the contents of the sidebar. These rules were kept.

The unsetting of border-radius and border-inline seems unnecessary - disabled these for Nova.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a477e2e22efb
https://hg.mozilla.org/integration/autoland/rev/cb172dd963ad
Fix broken sidebar borders and color mismatch for lightweight themes when using expand on hover in Nova. r=desktop-theme-reviewers,kcochrane

Comment 7

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/cb172dd963ad