2056669 - [Google Lens Fenix] Remove `uploadByUrl` endpoint from Google Lens integration

Status: RESOLVED FIXED

(Firefox for Android :: Search, task)

Description

[[:harrisono]]

Google has asked us to remove the uploadByUrl endpoint completely and just use the upload by bytes method instead.

uploadByUrl came from the early prototyping.

Comment 1

[[:harrisono]]

Attachment: Bug 2056669 - Remove `uploadByUrl` endpoint from Google Lens integration

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a13b0bef4c46
https://hg.mozilla.org/integration/autoland/rev/764b096ba873
Remove `uploadByUrl` endpoint from Google Lens integration r=android-reviewers,gmalekpour

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/764b096ba873

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/764b096ba873

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/764b096ba873

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/764b096ba873

Comment 7

[[:harrisono]]

Attachment: Bug 2056669 - Remove `uploadByUrl` endpoint from Google Lens integration

Original Revision: https://phabricator.services.mozilla.com/D313296

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Google has requested we remove the "uploadByUrl" endpoint completely from all integrations of Google Lens.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This is removing the backup upload method. The primary upload to Google Lens method is still existing.
  This just makes it so if the "upload by bytes" endpoint fails, the user is presented a message of "Google Lens not available at this time, try again later".
• String changes made/needed?: none.
• Is Android affected?: yes

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/aa87f8592c1e
https://hg.mozilla.org/releases/mozilla-beta/rev/e55c2a67db22

Comment 10

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: The previous uplift should also have been for the 153 dot release.
  Google requires us to remove the "uploadByUrl" endpoint. We can't begin the experiment without removing the "uploadByUrl" endpoint.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Low risk removal of secondary fallback API endpoint, users still have the primary API endpoint.
• String changes made/needed?: no
• Is Android affected?: yes

Comment 11

[[:harrisono]]

Attachment: Bug 2056669 - Remove `uploadByUrl` endpoint from Google Lens integration

Original Revision: https://phabricator.services.mozilla.com/D313296

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/8db9c5a08449
https://hg.mozilla.org/releases/mozilla-release/rev/d0532fcc9031